pulumi-aws icon indicating copy to clipboard operation
pulumi-aws copied to clipboard

Update the interface for ECS Container PortMapping with current options

Open chan-vince opened this issue 2 years ago • 4 comments
trafficstars

Update the ECS Container PortMapping interface to add in some fields that are in the API but currently missing from the interface. More context provided in the issue #2968.

I have done what felt obvious which was to update the interface. However I'm not really familiar with the full codegen(?) or dev process so I wouldn't be surprised if this is just the first step. Happy to continue further work with a bit of guidance :)

chan-vince avatar Nov 23 '23 23:11 chan-vince

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Nov 23 '23 23:11 github-actions[bot]

Hello and thank you for your pull request! :heart: :sparkles: It looks like you're directly modifying files in the language SDKs, many of which are autogenerated. Be sure any files you're editing do not begin with a code generation warning. For generated files, you will need to make changes in resources.go instead, and generate the code.

github-actions[bot] avatar Nov 23 '23 23:11 github-actions[bot]

/run-acceptance-tests

corymhall avatar Mar 27 '24 14:03 corymhall

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8453518971

pulumi-bot avatar Mar 27 '24 14:03 pulumi-bot

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Mar 28 '24 13:03 github-actions[bot]

/run-acceptance-tests

corymhall avatar Mar 28 '24 13:03 corymhall

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8468147023

pulumi-bot avatar Mar 28 '24 13:03 pulumi-bot