PATCH 0027-Restore-S3ConnURICleaningDisabled.patch

[t0yv0]

The change of interest is:

https://github.com/hashicorp/terraform-provider-aws/pull/33431

It appears that upstream is gradually migrating to AWS SDK v2 for Go. As part of these changes they removed S3ConnURICleaningDisabled which is now dead code upstream. For pulumi-aws, however, this code is still in use and handles force-deletion of the legacy bucket (internal/service/s3legacy/bucket_legacy.go). The patch reverts the deletion to keep upstream compiling under the patch-set in pulumi-aws.

[iwahbe]

@t0yv0 My understanding is that we don't need to "test" the patch, since it is necessary to ensure our code compiles. If we make changes to the legacy bucket such that our code compiles without this patch, we are safe to remove this patch?

Does this sound right?

[t0yv0]

Well that's a good point; that's one way to make the argument; but the other argument is for testing this is strong too. We're maintaining legacy bucket when upstream doesn't, has deleted the files and keeps changing things around. It could easily bit-rot and stop working. With this patch the use case I'm particularly concerned about is force-deletion, this is where this code is called. We could use making sure it's covered.