vue-tour icon indicating copy to clipboard operation
vue-tour copied to clipboard

docs(readme): added CDN link

Open HZooly opened this issue 4 years ago • 9 comments
trafficstars

As mentionned in #207

HZooly avatar Nov 12 '21 20:11 HZooly

@smitpatelx CDN link point to a fork of the current repository, but the original one.

HZooly avatar Nov 12 '21 20:11 HZooly

Check this, I already made that changes before months. I don't know what else should I do to change this. https://github.com/cdnjs/packages/blob/master/packages/v/vue-tour.json

smitpatelx avatar Nov 12 '21 22:11 smitpatelx

Then I don't get why GitHub button leads to your fork, is that a bug from cdnjs?

image

HZooly avatar Nov 12 '21 22:11 HZooly

Yes, i guess its not uptodate or it might be because of cache. They are using static files, so totally possible.

smitpatelx avatar Nov 12 '21 22:11 smitpatelx

Ok right! What about Vue Tour CSS? Don't you need it from CDN too?

HZooly avatar Nov 12 '21 22:11 HZooly

Yes you can add that as well. Made a PR to change description and asked question about the old link. https://github.com/cdnjs/packages/pull/893

smitpatelx avatar Nov 12 '21 22:11 smitpatelx

Added css files as well. Awaiting approval from cdnjs.

smitpatelx avatar Nov 12 '21 22:11 smitpatelx

Perfect! Waiting for cdnjs merge before merging this one. Thank you!

HZooly avatar Nov 12 '21 23:11 HZooly

You can also use jsDelivr which will also give you detailed stats per file and per version https://www.jsdelivr.com/package/npm/vue-tour

https://cdn.jsdelivr.net/npm/[email protected] https://cdn.jsdelivr.net/npm/[email protected]/dist/vue-tour.umd.min.js

jimaek avatar Nov 14 '21 17:11 jimaek