pulp-operator icon indicating copy to clipboard operation
pulp-operator copied to clipboard

Can't enable sha224 with sha1

Open apampurin opened this issue 9 months ago • 0 comments

Version pulp-operator:v1.0.0-beta.4 pulp-operator:v1.0.0-beta.5

Describe the bug I'm creating rpm repositiries for rhel9 and rhel7. I successfully uploaded rhel9 repos.

Then, I tried to upload rhel7 repo which is required to add sha1 shecksum in pulp CR which I've done as follow:

spec:
  allowed_content_checksums:
  - sha1

After that I found that some already uploaded artifacts with sha224 were removing, so I stopped pulp-rpm-update-content-checksums pod. I added sha224 and other to allowed_content_checksums like:

spec:
  allowed_content_checksums:
  - sha224
  - sha256
  - sha512
  - sha1
  - sha384

But handle-artifact-checksums job was not started. I've got error in pulp-operator-controller-manager logs:

2025-01-15T13:39:44Z	INFO	controller/controller.go:217	Starting workers	{"controller": "pulprestore", "controllerGroup": "repo-manager.pulpproject.org", "controllerKind": "PulpRestore", "worker count": 1}
2025-01-15T13:39:44Z	WARN	repo_manager/precheck.go:276	Checksum sha1 is deprecated by some Pulp plugins, it is not recommended using it in production.
2025-01-15T13:39:44Z	ERROR	repo_manager/precheck.go:271	Checksum sha224 is not valid!
github.com/pulp/pulp-operator/controllers/repo_manager.checkAllowedContentChecksums
	/workspace/controllers/repo_manager/precheck.go:271
github.com/pulp/pulp-operator/controllers/repo_manager.prechecks
	/workspace/controllers/repo_manager/precheck.go:80
github.com/pulp/pulp-operator/controllers/repo_manager.(*RepoManagerReconciler).Reconcile
	/workspace/controllers/repo_manager/controller.go:100
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:303
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:263
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:224

I can return sha224 with removing allowed_content_checksums from pulp CR, and artifacts will be restored. But how I can activate sha1 and sha224?

I see related conversation in https://github.com/pulp/pulp-operator/issues/1060, but I can't found answer to question above.

apampurin avatar Jan 15 '25 14:01 apampurin