pulp-operator icon indicating copy to clipboard operation
pulp-operator copied to clipboard

Update/Fix release script and csv

Open git-hyagi opened this issue 1 year ago • 0 comments

Describe the bug Releasing a new version of the operator using the release.sh script will fail community-operators and community-operators-prod pipelines because of:

  • missing metadata.annotations.support field (new required field)
  • containerImage is not used by any container in the csv
  • bundle replace version not found

and also some warnings:

Value : (pulp-operator.v1.0.0-beta.4) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
Value pulp-operator.v1.0.0-beta.4: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for cronjobs: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[4]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.Permissions[0].Rules[10]"]),

Expected behavior We should update the release.sh script to avoid these errors and/or manual intervention by:

  • adding the metadata.annotations.support: Community field in the pulp-operator.clusterserviceversion.yaml file
  • fixing the missing v in: https://github.com/pulp/pulp-operator/blob/852f1a063dd0a664e43c211c1707f5c0ec822015/release/release.sh#L69-L70
    • it should be:
  sed -i "s#containerImage: quay.io/pulp/pulp-operator:devel#containerImage: quay.io/pulp/pulp-operator:v${PULP_OPERATOR_RELEASE_VERSION}#g" $CSV_FILE
  echo "  replaces: pulp-operator.v${PULP_OPERATOR_REPLACE_VERSION}" >> $CSV_FILE

Additional context Maybe the warning should be handled through a separate issue. (Keeping it here for now)

git-hyagi avatar Jan 18 '24 21:01 git-hyagi