backlog
backlog copied to clipboard
pullreminders
As as user, I would like metrics and reminders to accumulate only when PRs have certain labels applied to them
Our teams often open PRs to take advantage of our CI processes, Github's diff viewer, and for various other reasons.
We use Pull Reminders to only remind for PRs with certain labels (eg. ready-for-review).
I'd like to extend this to the metrics gathered.
In other words, time-in-review should only accumulate when a PR has certain labels applied to it. Ideally this can account for all periods where a PR has a label applied (iow. labels can be removed/added at any time and the metrics should reflect that).
This will make our PR metrics more accurate.
@goodspark Thanks for submitting this! Makes a lot of sense. Will keep this as a standalone issue but also reference from https://github.com/pullreminders/backlog/issues/5
Also, it would be desirable if the logic accounted for how labels can be added and removed at any time. Eg: Sometimes we remove our 'review' label after someone has reviewed and it the PR clearly needs changes. It helps us filter from all the open PRs just down to the stuff that need reviewing. I'll update the description.
@goodspark Question - does your team use review requests? Or do you rely exclusively on labels to communicate when a PR is ready for review?
Mostly labels. An ideal were trying to get to is that anyone should be able to (or just 'should') review a PR. We haven't really codified review requests as part of our process, since the people who have the tribal knowledge are very few and they'd most likely be inundated with the requests.
So as an OSS maintainer for several orgs the common patterns I have seen include a couple of things that we do to filter out pull requests that are not ready. We use a filter to look for labels such as Status: Awaiting Response which are applied by maintainers as well as filter pull request titles for combinations of WIP:, [WIP], etc.
