pubs icon indicating copy to clipboard operation
pubs copied to clipboard

pubs note echo

Open dvklopfenstein opened this issue 5 years ago • 4 comments

Thank you so much for the pubs code.

I am making great use of the pubs note command and would like to add an --echo or -e arg so that I can do something like this:

$ pubs note Bramer_BSc_2016 -e
Text from the pubs/notes/Bramer_BSc_2016.txt file

And if there is no notes file for a citekey, we would see no text, like this:

$ pubs note AlRyalat_2019 -e

What do you think?

dvklopfenstein avatar Jan 08 '20 09:01 dvklopfenstein

@dvklopfenstein: I think that's a great feature. It's simple and may enhance the scripting possibilities of pubs notes a lot. Do you want to submit a PR, or just suggest the feature?

benureau avatar Jan 09 '20 03:01 benureau

Thank you for the great command-line bibliography tools and thank you for considering the addition of the echo feature to pubs notes.

I have implemented it in a local fork of pubs and have been using it in my research, but have held off submitting a PR due to needing to write a test. I'll get that test written and then open a PR.

dvklopfenstein avatar Jan 09 '20 17:01 dvklopfenstein

Wonderful. Will look at it when you submit it. No hurry.

benureau avatar Jan 10 '20 01:01 benureau

I just added the new code and test to do notes echo it is now under a new pull request https://github.com/pubs/pubs/pull/222

Thank you for the great code and thank you for considering my pull request.

dvklopfenstein avatar Apr 23 '20 19:04 dvklopfenstein