plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

Fix indentation on new.html.erb

Open lanefoxwood opened this issue 3 years ago • 7 comments

I believe the task was to set the indentation to 2 spaces throughout the document. I attempted to do this...and after combing the whole doc, I could only see about 20ish lines that needed changing. I hope that these changes are accurate. Thank you for reviewing!

Fixes #11077 original issue, comment

screenshot of proposed changes: Screen Shot 2022-09-13 at 15 26 45

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [X] PR is descriptively titled 📑 and links the original issue above 🔗
  • [X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [X] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [X] screenshots/GIFs are attached 📎 in case of UI updation
  • [X] ask @publiclab/reviewers for help, in a comment below

lanefoxwood avatar Sep 13 '22 13:09 lanefoxwood

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help 💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

welcome[bot] avatar Sep 13 '22 13:09 welcome[bot]

gitpod-io[bot] avatar Sep 13 '22 13:09 gitpod-io[bot]

@publiclab/reviewers thank you for stepping in to help!

ghost avatar Sep 13 '22 13:09 ghost

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8267797390/artifacts/361842876

github-actions[bot] avatar Sep 13 '22 13:09 github-actions[bot]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8295305072/artifacts/363756573

github-actions[bot] avatar Sep 14 '22 20:09 github-actions[bot]

Code Climate has analyzed commit 73b2a5a7 and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Sep 14 '22 21:09 qlty-cloud-legacy[bot]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8295880170/artifacts/363790706

github-actions[bot] avatar Sep 14 '22 21:09 github-actions[bot]

Resolved in #11133

TildaDares avatar Oct 13 '22 09:10 TildaDares

Thank you for working on this @lanefoxwood!

TildaDares avatar Oct 13 '22 09:10 TildaDares