plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

Positioning of Lock Icon is not in center of circle.

Open Radhika-Saini opened this issue 3 years ago • 15 comments

The Lock icon is found on the site by the following steps-

  1. Login
  2. In the community Dropdown, Click on Get Started.

2022-04-10 (3)

Radhika-Saini avatar Apr 09 '22 19:04 Radhika-Saini

@TildaDares I found a bug, Kindly review.

Radhika-Saini avatar Apr 09 '22 19:04 Radhika-Saini

Hi @Radhika-Saini, go ahead. Thanks!

TildaDares avatar Apr 10 '22 08:04 TildaDares

@TildaDares I am an outreachy applicant, Finding bugs and Suggesting Feature PR are enough for contribution or need more to get selected?

Radhika-Saini avatar Apr 10 '22 08:04 Radhika-Saini

Hi @Radhika-Saini, you need to make at least one contribution(PR).

TildaDares avatar Apr 10 '22 08:04 TildaDares

Ok, @TildaDares Thanks.

Radhika-Saini avatar Apr 10 '22 09:04 Radhika-Saini

If this issue is not resolved yet, can I take it up @TildaDares?

romasinha avatar Apr 14 '22 04:04 romasinha

@Radhika-Saini have you been able to fix the bug? do you mind me helping if you havent?

Ifetakuro avatar Apr 15 '22 14:04 Ifetakuro

@Radhika-Saini is this issue still open? If yes, can I help to resolve it.

rajvidg avatar Apr 15 '22 16:04 rajvidg

Yeah @Ifetakuro, @rajvidg we all can do this together.

Radhika-Saini avatar Apr 15 '22 18:04 Radhika-Saini

Yeah @Ifetakuro, @rajvidg we all can do this together.

Oh great :) , so, should we ask the mentors first or proceed?

rajvidg avatar Apr 15 '22 18:04 rajvidg

@Radhika-Saini @rajvidg once we get a go ahead from @TildaDares we should be able to work on it together :)

Ifetakuro avatar Apr 15 '22 18:04 Ifetakuro

@Radhika-Saini @rajvidg once we get a go ahead from @TildaDares we should be able to work on it together :)

Yes, I was also thinking the same. :)

rajvidg avatar Apr 15 '22 18:04 rajvidg

Hi @TildaDares, I have fixed this issue in pr https://github.com/publiclab/plots2/pull/11087/commits/050da3cb47e2aca7848a5b570511be6d23ef8b12 . Please review it. Thanks.

Sushil333 avatar Apr 21 '22 19:04 Sushil333

Hi @Sushil333, you haven't pushed to publiclab/plots2.

TildaDares avatar Apr 21 '22 19:04 TildaDares

Hi @Sushil333, you haven't pushed to publiclab/plots2.

Thank you for the reply. I already made a pull request https://github.com/publiclab/plots2/pull/11087 and this is another one. I think both are in same pr.

Sushil333 avatar Apr 21 '22 20:04 Sushil333

Closed in #11368

TildaDares avatar Sep 04 '22 15:09 TildaDares