Fixed the hard coded sorting for profiles search

[jstrickl-tunes]

The profile search was hard coded to perform only one type of sorting, so I removed that hard code in the controller and added in getting the users choice from the parameters.

Fixes #9334

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [✅] PR is descriptively titled 📑 and links the original issue above 🔗
• [ ✅] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• [✅ ] code is in uniquely-named feature branch and has no merge conflicts 📁
• [ ] screenshots/GIFs are attached 📎 in case of UI updation
• [ ] ask @publiclab/reviewers for help, in a comment below

[welcome[bot]]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help 💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[gitpod-io[bot]]

[codecov[bot]]

Codecov Report

Merging #10693 (ca27d6d) into main (4d31f1d) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #10693      +/-   ##
==========================================
+ Coverage   82.43%   82.45%   +0.01%     
==========================================
  Files          98       98              
  Lines        5990     5996       +6     
==========================================
+ Hits         4938     4944       +6     
  Misses       1052     1052              

Impacted Files	Coverage Δ
app/controllers/search_controller.rb	97.67% <100.00%> (ø)
app/services/search_service.rb	95.19% <100.00%> (+0.29%)	:arrow_up:

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5189402947/artifacts/157954797

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5189519584/artifacts/157962294

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5190655217/artifacts/158045944

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5194557821/artifacts/158330321

[TildaDares]

Hi @jstrickl-tunes, do you think you could add functional tests for this feature? Take a look at some test examples you can use as a guide https://github.com/publiclab/plots2/blob/dc60919196645d36fe751dd1b4ea0503c5748a13/test/functional/api/search_api_test.rb#L11-L30

Great job!!

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5537179448/artifacts/178094266

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5547966918/artifacts/178779847

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5548259001/artifacts/178798728

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5548398012/artifacts/178807528

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5551085237/artifacts/178997371

[qlty-cloud-legacy[bot]]

Code Climate has analyzed commit ca27d6d5 and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions[bot]]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/5551179721/artifacts/179003940

[stale[bot]]

Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label :tada: . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! :100: Thank you for your contributions! :raised_hands: :balloon:.