plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

For notes that replicate more than one activity, show in alert bar

Open ebarry opened this issue 4 years ago • 12 comments

Current situation Notes such as https://publiclab.org/notes/bhamster/08-06-2021/building-a-coqui-water-conductivity-sensor-and-analyzing-its-sound that replicate more than one activity only link to one activity in the blue alert bar. Screen Shot 2021-08-10 at 11 29 48 AM

The screenshot shows that the blue alert bar text "This is an attempt to replicate an activity." has a link target set for the words "an activity" --- see the link target previewed in the lower left hand corner of the screenshot above ^^

So, this note actually has two replication powertags: Screen Shot 2021-08-10 at 11 29 35 AM

Please describe the desired behavior.

It would be nice if the blue bar linked to both activities that are being replicated. Perhaps there's a way to rephrase the blue alert bar text? This might need a touch of design insight. CC @bhamster Thanks!

ebarry avatar Aug 10 '21 19:08 ebarry

@ebarry I think adding links to all activities that are being replicated would clutter the alert bar. I have 2 suggestions

  1. Linking it to another page where all the replicated activities are listed.
  2. Adding another message, something like view all the replicated activities in the sidebar (maybe written in a better manner).

Thanks!

Manasa2850 avatar Aug 14 '21 03:08 Manasa2850

I did some browsing to break this issue down a little further.

Here's where the blue alert is displayed in the codebase: https://github.com/publiclab/plots2/blob/2bb0cdd28c8d1a513b0161c402062f4edee4624d/app/views/notes/show.html.erb#L6

Here's where the exact text that's displayed is specified: https://github.com/publiclab/plots2/blob/2bb0cdd28c8d1a513b0161c402062f4edee4624d/config/locales/en.yml#L198-L200

Particularly, to me, it looks like something here needs to be changed to get the desired outcome:

<a href="/n/<% if !@preview %><%= @node.power_tag('replication') %><% end %>">
  <%= raw translation('notes.show.replication_link') %>
</a>

In production, @node.power_tag('replication') translates to 18313 for some reason, which leads to https://publiclab.org/n/18313

noi5e avatar Aug 16 '21 21:08 noi5e

@jywarren @TildaDares Can you please assign me this issue? want to work

subhangi2731 avatar Oct 17 '21 04:10 subhangi2731

Hi @subhangi2731, go ahead!

TildaDares avatar Oct 17 '21 19:10 TildaDares

thank you @TildaDares

subhangi2731 avatar Oct 18 '21 09:10 subhangi2731

Can I take up this issue? @TildaDares @ebarry

KarishmaVanwari avatar Nov 29 '21 11:11 KarishmaVanwari

Hi @subhangi2731, any updates? If you need any help, please feel free to ask.

TildaDares avatar Nov 30 '21 08:11 TildaDares

@KarishmaVanwari if we don’t get any response from @subhangi2731 I’ll assign this to you.

TildaDares avatar Nov 30 '21 08:11 TildaDares

@KarishmaVanwari if we don’t get any response from @subhangi2731 I’ll assign this to you.

Okay

KarishmaVanwari avatar Dec 01 '21 10:12 KarishmaVanwari

Hi @KarishmaVanwari, if you're still interested in working on this, I can assign it to you.

TildaDares avatar Dec 27 '21 10:12 TildaDares

Hi @TildaDares , I am still interested to work on this issue. You can assign me.

KarishmaVanwari avatar Dec 30 '21 17:12 KarishmaVanwari

Awesome! I’ll assign it to you

TildaDares avatar Dec 30 '21 18:12 TildaDares