leaflet-environmental-layers icon indicating copy to clipboard operation
leaflet-environmental-layers copied to clipboard

making the spinner stop after 10sec if the data is not loaded.

Open neelesh17 opened this issue 5 years ago • 4 comments

Fixes #290 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] PR is descriptively titled 📑 and links the original issue above 🔗
  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • [x] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [x] screenshots/GIFs are attached 📎 in case of UI updation
  • [x] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

neelesh17 avatar Feb 22 '20 06:02 neelesh17

@crisner I made the changes you asked me for. But the build keeps failing.

neelesh17 avatar Feb 25 '20 09:02 neelesh17

No worries @neelesh17. I'll take a look at it by the end of the day.

crisner avatar Feb 25 '20 11:02 crisner

Hey @crisner, the cypress checks for layerFilter is failing and i am not sure why it is happening. And all the functionality for spinner is done.

neelesh17 avatar Mar 09 '20 13:03 neelesh17

@neelesh17, let us put this on hold while we wait for a reply to https://github.com/publiclab/leaflet-environmental-layers/issues/290#issuecomment-593244921. As for the tests failing, it is because of the changes in a recent PR. There is an open PR with the fix. The tests will pass once the PR is reviewed and merged. Thanks!

crisner avatar Mar 09 '20 14:03 crisner