leaflet-environmental-layers
leaflet-environmental-layers copied to clipboard
making the spinner stop after 10sec if the data is not loaded.
Fixes #290 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [x] PR is descriptively titled 📑 and links the original issue above 🔗
- [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
- [x] code is in uniquely-named feature branch and has no merge conflicts 📁
- [x] screenshots/GIFs are attached 📎 in case of UI updation
- [x] ask
@publiclab/reviewersfor help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
@crisner I made the changes you asked me for. But the build keeps failing.
No worries @neelesh17. I'll take a look at it by the end of the day.
Hey @crisner, the cypress checks for layerFilter is failing and i am not sure why it is happening. And all the functionality for spinner is done.
@neelesh17, let us put this on hold while we wait for a reply to https://github.com/publiclab/leaflet-environmental-layers/issues/290#issuecomment-593244921. As for the tests failing, it is because of the changes in a recent PR. There is an open PR with the fix. The tests will pass once the PR is reviewed and merged. Thanks!