Bump ora from 5.4.1 to 6.1.2
Bumps ora from 5.4.1 to 6.1.2.
Release notes
Sourced from ora's releases.
v6.1.2
- Revert "Fix preserving stdin's pause state (#210)" f4e03ea
- Reason: sindresorhus/ora#211
https://github.com/sindresorhus/ora/compare/v6.1.1...v6.1.2
v6.1.1
https://github.com/sindresorhus/ora/compare/v6.1.0...v6.1.1
v6.1.0
- Expose the spinner
intervalas a getter 447812b- Internal refactoring. If you use any undocumented properties, this may break for you.
https://github.com/sindresorhus/ora/compare/v6.0.1...v6.1.0
v6.0.1
- Upgrade dependencies 26ba606
https://github.com/sindresorhus/ora/compare/v6.0.0...v6.0.1
v6.0.0
Breaking
- Require Node.js 12.20 ede1a54
- This package is now pure ESM. Please read this.
ora.promiseis now a named import calledoraPromise(#181) 9c01990
import {oraPromise} from 'ora';oraPromisenow returns the given promise instead ofthis(#181) 9c01990
- This lets you await it directly, which is more useful than chaining.
Improvements
- Improve performance of the
.clear()method (#182) d51c971
Commits
702d1fe6.1.2f4e03eaRevert "Fix preserving stdin's pause state (#210)"1c24e0f6.1.177ccc1eFix preserving stdin's pause state (#210)c2400db6.1.06a4150aRefactor447812bExpose the spinnerintervalas a getterc5026b76.0.126ba606Upgrade dependencies83646646.0.0- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Whoa that was a fast update.... anyways here were my notes from the previous:
ora.promise is now a named import called oraPromise ([#181](https://github-redirect.dependabot.com/sindresorhus/ora/issues/181)) 9c01990
import {oraPromise} from 'ora';
oraPromise now returns the given promise instead of this ([#181](https://github-redirect.dependabot.com/sindresorhus/ora/issues/181)) 9c01990
This lets you await it directly, which is more useful than chaining.
Referencing https://github.com/sindresorhus/ora/pull/181
Ora usages:
Looks like the first one is more relevant maybe... more use of asynchronous?
https://github.com/publiclab/image-sequencer/blob/3caa033c8febf5055c28f616b534933c00fcbe65/src/cli/sequencerSteps.js#L72-L87
https://github.com/publiclab/image-sequencer/blob/3caa033c8febf5055c28f616b534933c00fcbe65/src/cli/installModule.js#L11-L15
Yes, it now returns a promise instead of the spinner object:
https://github.com/sindresorhus/ora/pull/181/files#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15L229
So now we need to change starting on line 74 here, to receive spinnerPromise instead of spinnerObj, and to stop it differently on line 82-3?:
https://github.com/publiclab/image-sequencer/blob/3caa033c8febf5055c28f616b534933c00fcbe65/src/cli/sequencerSteps.js#L72-L87
Oh you know what, the error is actually about the require() usage:
internal/modules/cjs/loader.js:1102
throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
^
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/runner/work/image-sequencer/image-sequencer/node_modules/ora/index.js
require() of ES modules is not supported.
require() of /home/runner/work/image-sequencer/image-sequencer/node_modules/ora/index.js from /home/runner/work/image-sequencer/image-sequencer/src/cli/installModule.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/runner/work/image-sequencer/image-sequencer/node_modules/ora/package.json.
Maybe the promises stuff is not actually causing an issue... although we should check the spinner still stops properly.
The change is instead probably:
https://github.com/publiclab/image-sequencer/blob/3caa033c8febf5055c28f616b534933c00fcbe65/src/cli/installModule.js#L2
https://github.com/publiclab/image-sequencer/blob/3caa033c8febf5055c28f616b534933c00fcbe65/src/cli/sequencerSteps.js#L1