image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Option for variable frame rates to download as GIF option

Open rishabhshuklax opened this issue 5 years ago • 4 comments

Fixes #743

variable-frames

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [ ] code is in uniquely-named feature branch and has no merge conflicts
  • [ ] PR is descriptively titled
  • [ ] ask @publiclab/is-reviewers for help, in a comment below
  • [ ] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

rishabhshuklax avatar Feb 03 '20 18:02 rishabhshuklax

Codecov Report

Merging #1611 into main will increase coverage by 10.29%. The diff coverage is 63.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1611       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      132       +15     
  Lines        2344     2741      +397     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1793      +501     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

codecov[bot] avatar Feb 03 '20 18:02 codecov[bot]

@publiclab/is-reviewers please review this

rishabhshuklax avatar Feb 03 '20 18:02 rishabhshuklax

gitpod-io[bot] avatar Jul 12 '20 14:07 gitpod-io[bot]

image

  1. The frame duration unit is not shown
  2. We should no allow any frame rate (-ve or too low etc)

This could be merged if this is not a problem.

harshkhandeparkar avatar Jul 27 '21 21:07 harshkhandeparkar