Fixes #1402

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

[X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
[X] code is in uniquely-named feature branch and has no merge conflicts
[X] PR is descriptively titled
[X] ask @publiclab/is-reviewers for help, in a comment below
[X] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

pos

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

Dec 30 '19 20:12 ataata107

@publiclab/is-reviewers

Dec 30 '19 20:12 ataata107

Codecov Report

Merging #1403 into main will increase coverage by 10.17%. The diff coverage is 63.45%.

@@             Coverage Diff             @@
##             main    #1403       +/-   ##
===========================================
+ Coverage   55.11%   65.29%   +10.17%     
===========================================
  Files         117      132       +15     
  Lines        2344     2746      +402     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1793      +501     
+ Misses       1052      953       -99

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	`18.51% <ø> (ø)`
src/Modules.js	`100.00% <ø> (ø)`
src/modules/WebglDistort/Module.js	`2.29% <0.00%> (ø)`
src/ui/SetInputStep.js	`12.90% <0.00%> (-1.39%)`	:arrow_down:
src/modules/ColorHalftone/Module.js	`3.63% <3.63%> (ø)`
examples/lib/defaultHtmlStepUi.js	`11.05% <3.70%> (-1.15%)`	:arrow_down:
examples/lib/intermediateHtmlStepUi.js	`11.11% <5.55%> (+0.94%)`	:arrow_up:
examples/lib/insertPreview.js	`13.15% <20.00%> (-0.36%)`	:arrow_down:
src/util/getImageDimensions.js	`20.00% <20.00%> (ø)`
src/util/isGif.js	`20.00% <20.00%> (ø)`
... and 100 more

Dec 30 '19 20:12 codecov[bot]

pos2

Dec 31 '19 22:12 ataata107

Yes @anthony-zhou we shouldn't display NULL when cursor moves away. I have also put the text on top-right. Kindly Review

Dec 31 '19 22:12 ataata107

Hi all! What if we put the position with a "mouse" icon ( https://fontawesome.com/v4.7.0/icon/mouse-pointer) for compactness, and in the card header, to the left of the trash button?

Very cool!

On Wed, Jan 1, 2020 at 11:40 AM anthony-zhou [email protected] wrote:

@anthony-zhou approved this pull request.

Looks good!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/pull/1403?email_source=notifications&email_token=AAAF6J3KMPMGXKTVN5IXQBDQ3TBP5A5CNFSM4KBP4Y4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQO4PVA#pullrequestreview-337496020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J7UIEXTF77MIVALEMLQ3TBP5ANCNFSM4KBP4Y4A .

Jan 02 '20 17:01 jywarren

How about a crosshairs icon in the card header which when clicked will trigger the function after which when hovered over the image it will give x,y cordinates in the same way it is currently showing rgb channels?

Jan 05 '20 19:01 rishabhshuklax

Oh, that sounds cool! But, do we want it not to be on by default?

On Sun, Jan 5, 2020 at 2:28 PM Rishabh Shukla [email protected] wrote:

How about a crosshairs icon https://fontawesome.com/v4.7.0/icon/crosshairs in the card header which when clicked will trigger the function after which when hovered over the image it will give x,y cordinates in the same way it is currently showing rgb channels?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/pull/1403?email_source=notifications&email_token=AAAF6J2WYTVL73O2T2MIGETQ4IXSLA5CNFSM4KBP4Y4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEID5RJI#issuecomment-570939557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2XXR4STEOBWROGWMTQ4IXSLANCNFSM4KBP4Y4A .

Jan 06 '20 21:01 jywarren

We don't need position data for all the modules this way we can keep both of the features (position and rgba channel on hover) and keep the UI clean and maybe we can also show the rgba data of image the same way by using a color-picker-icon...maybe?

Jan 06 '20 22:01 rishabhshuklax

That's a cool idea! Yeah!

On Mon, Jan 6, 2020 at 5:21 PM Rishabh Shukla [email protected] wrote:

We don't need position data for all the modules this way we can keep both of the features (position and rgba channel on hover) and keep the UI clean and maybe we can also show the rgba data of image the same way by using a color-picker-icon...maybe?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/pull/1403?email_source=notifications&email_token=AAAF6J6QE6IMS77AQHYKBJTQ4OVFZA5CNFSM4KBP4Y4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIG7UWQ#issuecomment-571341402, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JZL2IEV7POS2S4X3Z3Q4OVFZANCNFSM4KBP4Y4A .

Jan 06 '20 22:01 jywarren

I will do the necessary changes and will commit by tomorrow.

Jan 07 '20 22:01 ataata107

@jywarren @blurry-x-face Added the crosshair icon. It looks really cool now, By the way I guess it should always be triggered on because we can get the idea of the RGB value and crosscheck it with the current position our cursor.

Jan 11 '20 14:01 ataata107

@ataata107 Could you please attach a working GIF?

Jan 11 '20 14:01 rishabhshuklax

ezgif com-video-to-gif (7)