PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

[Planning] Refine the Public Lab Rich Editor

Open NARUDESIGNS opened this issue 4 years ago • 9 comments

This issue contains a list of tasks for my project. This is list is subject to change as some tasks might be added later on or removed.

My Outreachy Proposal

PROJECT TASKS

  • [x] Resolve questions on transforming Jasmine to Jest tests
  • [x] Port more Jasmine files to Jest test
  • [x] Remove jasmine files that have been converted to jest test
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/757
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/758
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/771
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/775
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/773
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/785
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/788?notification_referrer_id=NT_kwDOAvbua7MyOTQwMTc4Mzc5OjQ5NzM3MzIz#pullrequestreview-855717985
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/789?notification_referrer_id=NT_kwDOAvbua7MyOTQwODI2ODkyOjQ5NzM3MzIz#event-5912045249
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/792?notification_referrer_id=NT_kwDOAvbua7MyOTQ0MDg4OTQxOjQ5NzM3MzIz#pullrequestreview-855716819
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/803
  • [x] #809 (in collaboration with @RaviAnand111)
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/800 (in collaboration with @RaviAnand111)
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/815
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/818
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/817
  • [x] Address spacing and padding issues across the editor page for congested elements. For example, buttons and values in the table popover are tightly packed together
  • [x] Style buttons and input fields in popovers to sync with the other buttons and inputs on the page
  • [x] https://github.com/publiclab/PublicLab.Editor/pull/826
  • [x] #833
  • [x] #820 (in collaboration with @RaviAnand111)
  • [x] #821 (in collaboration with @RaviAnand111)
  • [ ] Permanently show tip, modify tip to clearly express that the use of tab key or comma affirms a tag. Also, state that multiple-word tags should be separated using the hyphen (dash) symbol e.g "next-UI" instead of space e.g "next UI"
  • [x] #843
  • [ ] Refine the editor section
  • [x] Style editor tool buttons to match each other for consistency, centre it on mobile

FTO

  • [x] #782
  • [x] #802
  • [x] #836

NARUDESIGNS avatar Dec 06 '21 14:12 NARUDESIGNS

Hello, @TildaDares @jywarren @Tlazypanda kindly review my tasks list. Also just to clarify please, I don't have to tackle them based on the order they are listed, right? Thank you!

NARUDESIGNS avatar Dec 06 '21 14:12 NARUDESIGNS

Great work on breaking your tasks into smaller sub-tasks @NARUDESIGNS!

  • Rename tags section, centre elements, style input field to match other input fields. Permanently show tip, modify tip to clearly express that the use of tab or comma affirms a tag. Also, state that multiple-word tags should be separated using the hyphen (dash) symbol e.g "next-UI" instead of "next UI"

There's a lot going on with this task. Do you think maybe this could be broken up further?

TildaDares avatar Dec 07 '21 10:12 TildaDares

I just found out that you can convert a task list to an issue by using the Convert to issue button. That's cool!

TildaDares avatar Dec 07 '21 10:12 TildaDares

Great work on breaking your tasks into smaller sub-tasks @NARUDESIGNS!

  • Rename tags section, centre elements, style input field to match other input fields. Permanently show tip, modify tip to clearly express that the use of tab or comma affirms a tag. Also, state that multiple-word tags should be separated using the hyphen (dash) symbol e.g "next-UI" instead of "next UI"

There's a lot going on with this task. Do you think maybe this could be broken up further?

Yes, I agree with you @TildaDares. After the meeting yesterday, I realised that some of my task lists need to be broken up to further tasks. I remember @jywarren mentioned that ideally, a PR should do one thing but I was also worried that it will be a very long list of PRs if each PR did just one thing.

I've however broken down that task and will go through again to see which task needs to be broken down.

NARUDESIGNS avatar Dec 07 '21 11:12 NARUDESIGNS

It's ok to end up with a long list of PRs, although perhaps it's good to start with only 3-5 max open at a time?

On Tue, Dec 7, 2021, 6:15 AM Paul Ibeabuchi C. @.***> wrote:

Great work on breaking your tasks into smaller sub-tasks @NARUDESIGNS https://github.com/NARUDESIGNS!

  • Rename tags section, centre elements, style input field to match other input fields. Permanently show tip, modify tip to clearly express that the use of tab or comma affirms a tag. Also, state that multiple-word tags should be separated using the hyphen (dash) symbol e.g "next-UI" instead of "next UI"

There's a lot going on with this task. Do you think maybe this could be broken up further?

Yes, I agree with you @TildaDares https://github.com/TildaDares. After the meeting yesterday, I realised that some of my task lists need to be broken up to further tasks. I remember @jywarren https://github.com/jywarren mentioned that ideally, a PR should do one thing but I was also worried that it will be a very long list of PRs if each PR did just one thing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/PublicLab.Editor/issues/760#issuecomment-987827398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2QLD7JHR67MHFIJSTUPXUGFANCNFSM5JOWPNZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jywarren avatar Dec 07 '21 15:12 jywarren

It's ok to end up with a long list of PRs, although perhaps it's good to start with only 3-5 max open at a time? On Tue, Dec 7, 2021, 6:15 AM Paul Ibeabuchi C. @.***> wrote: Great work on breaking your tasks into smaller sub-tasks @NARUDESIGNS https://github.com/NARUDESIGNS! - Rename tags section, centre elements, style input field to match other input fields. Permanently show tip, modify tip to clearly express that the use of tab or comma affirms a tag. Also, state that multiple-word tags should be separated using the hyphen (dash) symbol e.g "next-UI" instead of "next UI" There's a lot going on with this task. Do you think maybe this could be broken up further? Yes, I agree with you @TildaDares https://github.com/TildaDares. After the meeting yesterday, I realised that some of my task lists need to be broken up to further tasks. I remember @jywarren https://github.com/jywarren mentioned that ideally, a PR should do one thing but I was also worried that it will be a very long list of PRs if each PR did just one thing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#760 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J2QLD7JHR67MHFIJSTUPXUGFANCNFSM5JOWPNZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Alright, thank you.

NARUDESIGNS avatar Dec 07 '21 17:12 NARUDESIGNS

I just found out that you can convert a task list to an issue by using the Convert to issue button. That's cool!

OMG I did NOT know that was a button for the longest time!!!! Amazing! But... maybe a UI fail? lol! ❤️

jywarren avatar Dec 07 '21 19:12 jywarren

I just found out that you can convert a task list to an issue by using the Convert to issue button. That's cool!

OMG I did NOT know that was a button for the longest time!!!! Amazing! But... maybe a UI fail? lol! ❤️

😂 It has a tool tip but we also missed that.

NARUDESIGNS avatar Dec 07 '21 19:12 NARUDESIGNS

This checklist is looking great @NARUDESIGNS !!

I was admiring this nice minimal way to hide the text editing options in the GitHub comment editor, btw, thought I'd add it here as inspiration:

image

jywarren avatar Mar 01 '22 17:03 jywarren