PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

Switching between modes leads to html tags rendering for center aligned text

Open shreyaa-s-zz opened this issue 5 years ago • 10 comments

Description: Text is selected and center aligned. A string of text is selected with the center aligned text as substring and center aligned, and then switching to markdown mode. The selected part is rendered as HTML tags. Switching back to rich text editor leads to loss of data.

simplescreenrecorder-2020-06-05_17 13 06

(Test conducted on master branch)

What might be the probable causes?

shreyaa-s-zz avatar Jun 05 '20 12:06 shreyaa-s-zz

@jywarren @emilyashley @VladimirMikulic @cesswairimu @Shulammite-Aso @NitinBhasneria @keshav234156 any idea why this might be happening? Or where to look for the error?

cypherean avatar Jun 10 '20 12:06 cypherean

@shreyaa-sharmaa great catch :100: ... this is weird...tried a couple of other formatting like bold-ing and the table remains intact after bold-ing and switching back between the modes..also realized if you also center-align the table the data is not lost.. :thinking: no idea why this is happening..

cesswairimu avatar Jun 11 '20 21:06 cesswairimu

As a beginner, I would like to work on this issue, can anyone help me by pointing out how and where to start? I have an intermediate level knowledge of JS . @cesswairimu @shreyaa-s-zz @jywarren

SteveSayantan avatar Jun 15 '22 17:06 SteveSayantan

Hi @SteveSayantan and welcome. We would love your help! Have you setup the project yet? if not, you can find the steps to install here under "Installation" also overall info about the project and the modules and how to run it can be found there. Feel free to reach out if you are stuck somewhere or have other questions. thanks

cesswairimu avatar Jun 17 '22 13:06 cesswairimu

@cesswairimu thanks for the response!! Actually, I am having difficulty understand the code i.e. which file to change and how everything is working. Could you please suggest a beginners-friendly issue for getting started? I have installed the repo and all the packages successfully.

SteveSayantan avatar Jun 19 '22 05:06 SteveSayantan

I see, I did go through the issues and my judgement on it being "beginner friendly" maybe flawed( not so good with js) but how does this one look https://github.com/publiclab/PublicLab.Editor/issues/609 ? You may need to check if the issue is still persisting. thanks

cesswairimu avatar Jun 24 '22 12:06 cesswairimu

Hey @cesswairimu I looked into the issue, but still can not figure out anything. Anyways, thanks for your response.

SteveSayantan avatar Jul 08 '22 15:07 SteveSayantan

Sorry @SteveSayantan I couldn't help much, Tagging @TildaDares, if you do come across any good JS second issue kindly tag @SteveSayantan

cesswairimu avatar Jul 10 '22 08:07 cesswairimu

Hi @cesswairimu, I opened an issue here https://github.com/publiclab/plots2/issues/11246 and tagged @SteveSayantan. Let me know if you need any help with that issue.

TildaDares avatar Jul 10 '22 08:07 TildaDares

Awesome🎉🎉🎉. Thanks a bunch @TildaDares

cesswairimu avatar Jul 10 '22 08:07 cesswairimu