Leaflet.DistortableImage
Leaflet.DistortableImage copied to clipboard
Modified function getCmPerPixel to es6 funcion in src/util/ImageUtil.js
Fixes #598 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [x] PR is descriptively titled π and links the original issue above π
- [x] tests pass -- look for a green checkbox βοΈ a few minutes after opening your PR -- or run tests locally with
grunt test - [x] code is in uniquely-named feature branch and has no merge conflicts π
- [ ] screenshots/GIFs are attached π in case of UI updates
- [x] @mention the original creator of the issue in a comment below for help or for a review
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! πππ
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! π
Then, you can say hello in our chatroom & share a link to this PR to get a review! π β
Modified function getCmPerPixel to es6 funcion in src/util/ImageUtil.js #1164
Hi @kabuur, the function is fine as it is. You donβt have to change it to an ES6 function. Thank you!
You are only supposed to change the var keyword to let/const. Please take a look at the issue description to know the change required https://github.com/publiclab/Leaflet.DistortableImage/issues/1086
Hi! Sorry about this, but we close FTOs with no updates or replies because we assume they have been abandoned. This is to give other contributors a change, as these types of issues are high in demand now.
If you'd like to try again with a new FTO, we welcome you to!