Leaflet.DistortableImage icon indicating copy to clipboard operation
Leaflet.DistortableImage copied to clipboard

Display url where images came from, in MapKnitter Lite interface

Open jywarren opened this issue 3 years ago • 10 comments

When using MapKnitter Lite at https://publiclab.github.io/Leaflet.DistortableImage/examples/archive, when images begin to load, we could show a sentence about where they were loaded from (just displaying the URL which was input in the previous step):

Screenshot_20221014-081354

We could insert a line outside this block, or possibly before it:

https://github.com/publiclab/Leaflet.DistortableImage/blob/6e426d8370db8a24725f00cc5952e7533dbdf135/examples/archive.html#L116-L123

input.value is the URL that was input. We can create a <p> tag and say "images fetched from LINK" where LINK is the URL. Even better, it could be a link itself!

Would someone who's done a first timers only issue already like to take this up?

jywarren avatar Oct 13 '22 23:10 jywarren

@jywarren i'd like to claim this issue, i have done my FTO

7malikk avatar Oct 13 '22 23:10 7malikk

Ok @7malikk how would you approach this? Thank you!

jywarren avatar Oct 13 '22 23:10 jywarren

@jywarren I would create an <p> tag with the text like you stated 'Images fetched from here' where "here" would be wrapped in an <a> tag with href=input.value before the code block.

What do you think?

7malikk avatar Oct 13 '22 23:10 7malikk

Sounds good, would you like to open a PR?

jywarren avatar Oct 13 '22 23:10 jywarren

Sounds good, would you like to open a PR?

Yes, I would, I'll get on it right away

7malikk avatar Oct 13 '22 23:10 7malikk

id like to try this

abd123codes avatar Oct 13 '22 23:10 abd123codes

Maybe you could even just modify line 120?

jywarren avatar Oct 14 '22 00:10 jywarren

@jywarren thank you, ill work on it

abd123codes avatar Oct 14 '22 00:10 abd123codes

Hi @THEDARKMAN007 it looks like @7malikk has already begun here. Maybe you could look over the PR and offer any suggestions, or we can try finding another task for you soon?

jywarren avatar Oct 15 '22 17:10 jywarren

@jywarren I would like to go over the PR or if there is another task i would like to do that

Tammy-Ajoko avatar Oct 15 '22 18:10 Tammy-Ajoko

Hello @jywarren We can close this issue as we already resolved it in #1154

7malikk avatar Oct 16 '22 22:10 7malikk

Resolved in #1154. Thanks all!

TildaDares avatar Oct 21 '22 11:10 TildaDares