Leaflet.DistortableImage
Leaflet.DistortableImage copied to clipboard
publiclab
Create a new header in the Readme linking to Mapknitter Lite
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!
We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and look through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
- [ ] 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋
Claiming an issue
Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.
And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.
- [ ] 📝 Update the file README.md in the
Leaflet.DistortableImagerepository (press the little pen Icon) and edit the line as shown below.
See this page for some help in taking your first steps!
Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:
+ 46 ### MapKnitter Lite
+ 47
+ 48 Check out an early prototype of the Mapknitter Lite project [here](https://publiclab.github.io/Leaflet.DistortableImage/examples/archive)
+ 49
-
[ ] 💾 Commit your changes
-
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
-
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
-
You can also edit files directly in your browser and open a pull request from there.
- [ ] 🏁 Done Ask in comments for a review :)
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
(This issue was created by First-Timers-Bot.)
Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help. Please follow the issue template to help us help you 👍🎉😄 If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸 You can make a gif too! Do join our Gitter channel for some brainstorming discussions.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello, @jywarren, @TildaDares here is an issue to help out with first-timers.
Hi @7malikk, thank you for opening this issue. I think the initial link should be left as is because it is meant to serve as an example for users. Maybe we create another header with the title Mapknitter Lite that contains the link to the new link.
What do you think?
Hi @7malikk, thank you for opening this issue. I think the initial link should be left as is because it is meant to serve as an example for users. Maybe we create another header with the title
Mapknitter Litethat contains the link to the new link.What do you think?
That sounds a lot better, I'll make the changes and ping you. Thank you for the feedback. @TildaDares
@TildaDares Hello again, I've made the changes concerning creating a header new header and not replacing and refactoring. Kindly review and let me know your thoughts. Thank you.
@Teslimsama I believe @TildaDares is following a particular order from 11105, if you have made a request for an FTO, kindly exercise patience you would be assigned to an issue.
In the meantime @TildaDares could you review and attach a label here, Thank you
This looks great @7malikk!
Can you also specify what line in the file the change should be added? This will make it easier for contributors to work on it. Thank you and great work!
This looks great @7malikk!
Can you also specify what line in the file the change should be added? This will make it easier for contributors to work on it. Thank you and great work!
Alright @TildaDares Will do that now and ping you. Thank you for the feedback.
Hello, @TildaDares Kindly check out the update specifying the line to be changed. Thank you
Hi @7malikk and @TildaDares I found this reply beneath my request for an FTO, but going through the chats it seems it should be left as is.. I'd appreciate more clarity on it.
Thanks
@7malikk the issue seems to be on line 36 - 49, please confirm this while i work on it, thanks
@7malikk the issue seems to be on line 36 - 49, please confirm this while i work on it, thanks
Thank you @Onyi-X, I've made the corrections, you should insert the code in at line 36.
Hi @Onyi-X, this issue has been reserved. You can request for an issue here publiclab/plots2#11105. Thank you!
@TildaDares Hello there, this issue hasn't been resolved and many haven't had a chance to resolve an issue.
