Domantas Petrauskas

Results 73 comments of Domantas Petrauskas
trafficstars

No, because that PR does not expose these bundler related `node` invocations that I have linked above. New setting is the only way. Do not see a problem here -...

@julienrf @sjrd comments would be appreciated. Could I get some permissions to run CI at will, scripted tests are kind of clunky on my local machine. I could fix up...

Also, this very much breaks the backwards compatibility, but I assume that it is fine since the plugin is not v1 yet 😅 Let me know if that is not...

@julienrf @sjrd Could you review this?

@sjrd Thank you for a very thorough review! I will make the changes as requested.

@sjrd I think I made all of the modifications you requested, PR is ready for a review. I also updated docs.

There is a really old unmerged PR that solves this - https://github.com/scalacenter/scalajs-bundler/pull/408.

@evbo Good eye, I did not spot that in docs. I will implement your suggestion. Maybe adding the stack trace would be a good idea too.

Looking at CI setup, it should fix itself up upon next commit to main, but we should probably only publish to GitHub Pages only on tags, rather than every commit...

@mbilski Would you consider this? I can create the PR.