Peter Sobolewski

Results 493 comments of Peter Sobolewski
trafficstars

Yeah, I got it as well: https://github.com/napari/napari/actions/runs/3245198568/jobs/5322414844 @czaki had some input re: possibly blocking this version: https://github.com/napari/napari/pull/5213#issuecomment-1278186737

Just checked, on my end: https://github.com/napari/napari/issues/5199 is fixed. Meanwhile, the issues with surfaces from here: https://github.com/napari/napari/pull/5154 remain fixed. Likewise, the original test example for #4935 is also fine: Great catch...

Is it worth adding a `triaged` or `waiting for OP`/`info needed` to issue labels? There's a number of open issues that have been replied too and are waiting for the...

@isabela-pf I think the issue is that as of https://github.com/napari/napari/pull/5216 all of those docs are now here: [napari/docs](https://github.com/napari/docs) I'm not sure what the best path is for you to `move`...

@Carreau WOW! For a total neophyte, can you clarify how/where you got: ``` # export patches for all the commits in this PR, 4f68ba.... being the parent of 14c9b14... $...

> You mean `4f68ba.... being the parent of 14c9b14...` ? Yes, this was what I was wondering about. Thanks for the detailed explanation and patience! 🙏 ❤️

This PR also addresses the fact that if you use multiple viewers, then changing the theme of one changes them all. See: https://github.com/napari/napari/issues/5062#issuecomment-1259133016 Try: ``` import napari viewer1 = napari.Viewer()...

> Seems good. I wonder if it would be a good idea to use a notification pop-up to indicate what theme is the newly selected? You mean beyond the visual?...

> > You mean beyond the visual? Also, in which case? I assume, the keybind toggle? > > I guess seeing the name pop after the toggle can be useful...

I think adding a test for the `toggle_theme` behavior would be a good idea, but it seems it's currently untested. I was thinking just setting the theme in settings vs....