prysm icon indicating copy to clipboard operation
prysm copied to clipboard

fix: resolve the errors in ```GetLightClientUpdatesByRange``` function

Open rupam-04 opened this issue 1 year ago • 2 comments
trafficstars

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  1. Remove this line
  2. Return HandleError in places where continue is used inside if err != nil
  3. Make this requirement 1 vote and not 66%

Which issues(s) does this PR fix?

Fixes #14170

Other notes for review

I am yet to add unit tests for the 3rd change

rupam-04 avatar Jul 02 '24 14:07 rupam-04

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 02 '24 14:07 CLAassistant

Let's not merge without tests to make sure we don't forget about them

tests added! Pls let me know if any more changes are required

rupam-04 avatar Jul 02 '24 21:07 rupam-04