proxy-wasm-rust-sdk

proxy-wasm-rust-sdk copied to clipboard

### Summary * HTTP spec allows [arbitrary octets in header values](https://tools.ietf.org/html/rfc7230#page-25) * However, `Rust SDK` is using `&str` type that is limited to UTF-8 strings only * It is not...

yskopets

`hostcalls::get_map` crashes Envoy when an HTTP header value is not a UTF-8 encoded string

1

## Summary * HTTP spec allows [arbitrary octets in header values](https://tools.ietf.org/html/rfc7230#page-25) * However, `Rust SDK` is using `String` type that is limited to UTF-8 strings only * `hostcalls::get_map` panics when...

yskopets

The library could define feature flags corresponding to the filter type. For e.g. a tcp feature flag would enable the StreamContextTrait, and an http feature flag the HTTPContextTrait, this will...

kanishkarj

Aren't the lifetimes of various hostcalls which are publically available now fixed to that of Context/RootContext? If it is so wouldn't it be better to make the hostcall module private...

kanishkarj

How to handle HTTP request callback in "on_tick" method

1

fn on_tick(&mut self) { unsafe { self.dispatch_http_call( &VM_CONFIG_GLBOAL.gatewaycluster, vec![ (":method", "GET"), ( ":path", "/hello", ), (":authority","hello"), ], None, vec![], Duration::from_secs(1), ) .unwrap(); } }

pjjwpc

docs: functions documented with examples

13

In-Code Documentation for the following functions: **RootContext**: - `on_vm_start()` - `get_vm_configuration()` - `on_configure()` - `get_plugin_configuration()` - `set_tick_period()` - `on_tick()` **Context**: - `dispatch_http_call()` - `on_http_call_response()` - `get_http_call_response_headers()` - `get_http_call_response_headers_bytes()` - `get_http_call_response_header()`...

antonengelhardt

Health check

2

Hey, Is there any way to find out if the envoy has started the plugin and finished the configuration? It would be nice for liveness and readiness checks in Kubernetes....

antonengelhardt

PiotrSikora

Consider adding a [$file:$line] prefix to logs

1

The C++ SDK logs messages in this format: `[$file:$line]::$function $message` Via these macros: https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/blob/921039ae983ce053bf5cba78a85a3c08ff9791e5/proxy_wasm_api.h#L84-L92 The Rust SDK just logs the message: https://github.com/proxy-wasm/proxy-wasm-rust-sdk/blob/9b4b4a576ca28007b46a8f9aaff1ac9baa165cf0/src/logger.rs#L66-L67 File and line are supported in log::Record: https://docs.rs/log/latest/log/struct.Record.html...

martijneken

on_http_response_body seems to be capped at 615 bytes

2

Doesn't matter what I do, seems like I can't get to process more than 615 bytes on on_http_response_body. Is this 615byte value somewhere configurable?

mvniekerk