proxy-wasm-rust-sdk icon indicating copy to clipboard operation
proxy-wasm-rust-sdk copied to clipboard

Introduce on_create_child_context hook for creating non root contexts

Open unleashed opened this issue 4 years ago • 4 comments

This is based on previous work from @yskopets for creating child contexts via a hook in the root context (#6).

The patches first introduce the mechanism, then change the examples to make use of it, and finally remove the other currently existing methods in a breaking change to both simplify usage by having a single way to do this and clean up some of the code which should no longer be necessary. Compile-tested all examples after every patch.

Feel free to use or cherry pick partially or as needed.

unleashed avatar Dec 23 '20 00:12 unleashed

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 23 '20 00:12 google-cla[bot]

@googlebot I signed it!

unleashed avatar Dec 23 '20 00:12 unleashed

Hi @unleashed! Sorry, I've missed the email notifications for your PRs.

Is this only a "style rewrite" of what was already implemented in #34, or am I missing something? In any case, while I agree that this is a nicer interface, the next version of the ABI is most likely going to remove generic context type, and plugins will be able to support multiple extensions points (e.g. both HTTP and TCP), so we're going to need typed constructors, which this PR removes.

PiotrSikora avatar Feb 26 '21 09:02 PiotrSikora

Yes, this is a rewrite of #34 with a better user development experience and slightly nicer internal structure.

So if we'll need typed constructors anyway it's not worth it to merge this, but I'd like to take a look and see how we could improve on the current interface while allowing the incoming changes. Do you have a link to these changes and/or to a place where the ABI evolution is being discussed?

unleashed avatar Feb 26 '21 11:02 unleashed