Introduce on_create_child_context hook for creating non root contexts
This is based on previous work from @yskopets for creating child contexts via a hook in the root context (#6).
The patches first introduce the mechanism, then change the examples to make use of it, and finally remove the other currently existing methods in a breaking change to both simplify usage by having a single way to do this and clean up some of the code which should no longer be necessary. Compile-tested all examples after every patch.
Feel free to use or cherry pick partially or as needed.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Hi @unleashed! Sorry, I've missed the email notifications for your PRs.
Is this only a "style rewrite" of what was already implemented in #34, or am I missing something? In any case, while I agree that this is a nicer interface, the next version of the ABI is most likely going to remove generic context type, and plugins will be able to support multiple extensions points (e.g. both HTTP and TCP), so we're going to need typed constructors, which this PR removes.
Yes, this is a rewrite of #34 with a better user development experience and slightly nicer internal structure.
So if we'll need typed constructors anyway it's not worth it to merge this, but I'd like to take a look and see how we could improve on the current interface while allowing the incoming changes. Do you have a link to these changes and/or to a place where the ABI evolution is being discussed?