proxy-wasm-rust-sdk icon indicating copy to clipboard operation
proxy-wasm-rust-sdk copied to clipboard

Add missing parameter to on_http_response_trailers

Open casimiro opened this issue 3 years ago • 2 comments

Proxy wasm spec defines proxy_on_http_trailers as a 3 parameter function: context_id, num_trailers, end_of_stream. This PR adds the missing end_of_stream parameter.

casimiro avatar Jul 05 '22 21:07 casimiro

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 05 '22 21:07 google-cla[bot]

Hi @casimiro, apologies for the late response, and thanks for the contribution!

The current code is fine (otherwise, it wouldn't work with the existing host implementations). The issue is that there is no written specification for the Proxy-Wasm ABI v0.2.1, which is implemented by Envoy, MSON and all the SDKs (but writting it down is my primary task for the next 2 weeks).

Where did you run into this issue?

PiotrSikora avatar Jul 22 '22 01:07 PiotrSikora

Hi @PiotrSikora, I apologize for the ultra late response! I ran into this when experimenting with adding http trailers support to ngx_wasm_module. I assumed the end_of_stream argument was missing based on the late vNEXT spec which included end_of_stream as part of proxy_on_http_response_trailers.

Thank you for the response.

casimiro avatar Mar 12 '24 16:03 casimiro