proxy-wasm-rust-sdk icon indicating copy to clipboard operation
proxy-wasm-rust-sdk copied to clipboard

Allow arbitrary bytes as upstream name of grpc call

Open krdln opened this issue 4 years ago • 3 comments

Envoy allows the upstream to be serialized GrpcService message, but the proxy-wasm API allows only &str. (why use GrpcService message – to be able to connect to arbitrary upstream not predefined in envoy's clusters). This functionality seems to be supported by envoy so it makes sense to expose it in SDK.

This is obviously a breaking change, not sure how to make it non-breaking though (I thought about impl AsRef<u8>, but that would break object safety, I guess. Perhaps a separate trait method would a better solution?)

I've also looked a bit in the spec, in which the upstream argument is called grpc_service (hinting the use of formentioned GrpcService message), but in your PR, this argument is called just upstream_name. So thus I'm confused on the state of that feature, can you shed some light there?

krdln avatar Sep 16 '21 12:09 krdln

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 16 '21 12:09 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 16 '21 12:09 google-cla[bot]

I've also looked a bit in the spec, in which the upstream argument is called grpc_service (hinting the use of formentioned GrpcService message), but in your PR, this argument is called just upstream_name. So thus I'm confused on the state of that feature, can you shed some light there?

IMHO, the ability to declare upstreams in Envoy's implementation was a mistake and should be removed (but that's a bit tricky, since Istio Telemetry plugins are using it), since it breaks sandboxing in a pretty fundamental way.

Is there any specific reason why you want/need this feature?

PiotrSikora avatar Apr 05 '22 03:04 PiotrSikora