Allow arbitrary bytes as upstream name of grpc call
Envoy allows the upstream to be serialized GrpcService message, but the proxy-wasm API allows only &str. (why use GrpcService message – to be able to connect to arbitrary upstream not predefined in envoy's clusters). This functionality seems to be supported by envoy so it makes sense to expose it in SDK.
This is obviously a breaking change, not sure how to make it non-breaking though (I thought about impl AsRef<u8>, but that would break object safety, I guess. Perhaps a separate trait method would a better solution?)
I've also looked a bit in the spec, in which the upstream argument is called grpc_service (hinting the use of formentioned GrpcService message), but in your PR, this argument is called just upstream_name. So thus I'm confused on the state of that feature, can you shed some light there?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
I've also looked a bit in the spec, in which the
upstreamargument is calledgrpc_service(hinting the use of formentioned GrpcService message), but in your PR, this argument is called justupstream_name. So thus I'm confused on the state of that feature, can you shed some light there?
IMHO, the ability to declare upstreams in Envoy's implementation was a mistake and should be removed (but that's a bit tricky, since Istio Telemetry plugins are using it), since it breaks sandboxing in a pretty fundamental way.
Is there any specific reason why you want/need this feature?