proxy-wasm-cpp-host
proxy-wasm-cpp-host copied to clipboard
proxy-wasm
Fix references to prefix_wasm_api
References to include/wasm.h changed to crates/c-api/include/wasm.h, so the prefixed api output needs to change as well. Fixes #418
@keithmattix The change looks fine, but could you please confirm that it fixes the build and tests with --define=engine=multi? The CI doesn't check that configuration due to time constraints. Thanks!
@PiotrSikora I at least got past the error @wbpcode reported in #418, but am now dealing with wasmedge failures. I haven't been able to get past them yet, but will keep trying. If @wbpcode has a working setup, they may be able to confirm before I can. I think the wasmedge compilation step is considering all of my warnings as errors and I'm trying to find where I can disable that
@wbpcode @mpwarres could you verify if this fixes the multi-engine builds?
@PiotrSikora FWIW, I faced the same problem as in #418 and arrived to the same fix as @keithmattix did. I checked that it addresses the problem for me and the command from #418 works for me now:
bazel build --define=engine=multi :lib
INFO: Build option --define has changed, discarding analysis cache.
INFO: Analyzed target //:lib (0 packages loaded, 71587 targets configured).
INFO: Found 1 target...
Target //:lib up-to-date (nothing to build)
INFO: Elapsed time: 3.186s, Critical Path: 0.70s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
Would it count as verification enough to merge this PR?
@mpwarres @martijneken could you guys review and merge it? Thanks!
Ping?
Sorry for the delay and thanks for the nudge, this fell through the cracks. Thanks for the fix!
