proxy-wasm-cpp-host
proxy-wasm-cpp-host copied to clipboard
Do not reverse bytes for nullvm
This fixes the following istio proxy test on s390x: https://github.com/istio/proxy/blob/master/test/envoye2e/tcp_metadata_exchange/tcp_metadata_exchange_test.go Resolves https://github.com/proxy-wasm/proxy-wasm-cpp-host/issues/294
@PiotrSikora @mathetake can you please review? This is a follow-up change for https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/198. Thanks.
@PiotrSikora @mathetake would you please review this? Initial big-endian changes have already been merged in https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/198, but now I'd like to fix null-vm use case. Thanks.
could you elaborate on what's the error in the test, and how does this solve it?
@mathetake thanks for the review. I've opened an issue and added the error details https://github.com/proxy-wasm/proxy-wasm-cpp-host/issues/294. Can you please take a look?
@PiotrSikora @mathetake would you please review this? Initial big-endian changes have already been merged in #198, but now I'd like to fix null-vm use case. Thanks.
Could you add a test that fails without this change? We cannot rely on tests 3 repositories downstream.
@PiotrSikora thanks for the review, I've made the proposed changes, can you please take a look?
@PiotrSikora I've made the requested changes:
- Moved the calls to isWasmByteOrder() into htowasm/wasmtoh macros, now it should be removed by preprocessor for non-s390x.
- Added surrounding brackets to htowasm/wasmtoh
- Removed debug leftover can you please review? Thanks.
@mpwarres thanks for the review, please see my comments.
@PiotrSikora and/or @mathetake , I've finished my pass--this now awaits your approval.
@PiotrSikora I've made the changes, can you please take a look?
Thanks!