laravel-ffmpeg icon indicating copy to clipboard operation
laravel-ffmpeg copied to clipboard

Bug fix

Open SadeghPM opened this issue 2 years ago • 2 comments

When set disk on construct function we must return class instance.

SadeghPM avatar Jan 28 '23 07:01 SadeghPM

I think it's not necessary to add a return statement in the __construct method in Laravel. The __construct method is automatically called when an object is created from a class, and its purpose is to initialize the properties of the object. It's common to set up dependencies or perform other setup tasks in the __construct method, but the method does not require a return statement because its purpose is to modify the object itself, rather than returning a value.

aronquiray avatar Feb 01 '23 01:02 aronquiray

@aronquiray ok but think what is the purpose of $disk in construct? if we don't return class instance, $disk is useless.

SadeghPM avatar Feb 01 '23 06:02 SadeghPM

Hey, thanks for your contribution, I dont think that this PR will ever get merged, you may close it.

nagi1 avatar Mar 25 '25 10:03 nagi1