laravel-ffmpeg icon indicating copy to clipboard operation
laravel-ffmpeg copied to clipboard

Too few arguments to function FilesystemAdapter::setVisibility()

Open ateamcms opened this issue 2 years ago • 1 comments

Hello, get error in line https://github.com/protonemedia/laravel-ffmpeg/blob/main/src/Filesystem/Media.php#L151

With forwards call to FilesystemAdapter method setVisibility expect 2 arguments ($path and $visibility), but in your code you pass only $visibility (but in previous method in Media.php, called copyAllFromTemporaryDirectory you pass two arguments and it's work).

Can you please fix that method with something like this?

public function setVisibility(string $path, string $visibility = null)
{
    $disk = $this->getDisk();

    if ($visibility && $disk->isLocalDisk()) {
        $disk->setVisibility($path, $visibility);
    }

    return $this;
}

and this in https://github.com/protonemedia/laravel-ffmpeg/blob/main/src/Exporters/MediaExporter.php#L242

if ($outputMedia) {
    $outputMedia->copyAllFromTemporaryDirectory($this->visibility);
    $outputMedia->setVisibility($path, $this->visibility);
}

Laravel 9.45.0 PHP 8.1 laravel-ffmpeg 8.2.0

Thank you

ateamcms avatar Dec 21 '22 14:12 ateamcms

same issue

kslr avatar Aug 26 '23 14:08 kslr

Fixed in v8.7.1

pascalbaljet avatar Apr 01 '25 21:04 pascalbaljet