protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

fix(php): do not throw deprecated warning on field getters for default values

Open bshaffer opened this issue 7 months ago • 5 comments
trafficstars

backports the fix in #17788 for the 25.x branch, fixes https://github.com/protocolbuffers/protobuf/issues/13428 in 25.x branch

bshaffer avatar Apr 01 '25 17:04 bshaffer

Hi Brent, from April 7 we will drop 25 support for everything except Java

anandolee avatar Apr 01 '25 21:04 anandolee

@anandolee When you say "drop", do you mean "release"? And if so can we really try to get this merged before then?

bshaffer avatar Apr 04 '25 16:04 bshaffer

@anandolee My customer would very much appreciate this being merged.

rosmo avatar Apr 07 '25 11:04 rosmo

Expanding on this to say that because the googleapi public protos are on protobuf 25, all the client libraries generate messages using that protobuf version. We are trying to update it, but it's difficult since we need to do it for ALL languages at once, and there are some breaking change concerns with some languages for upgrading to 26.

This is a simple fix which is backported to 25 so we can resolve the issue for our customers now, instead of having to wait to upgrade protobuf for all the client libraries (which may be soon, and it may not be).

bshaffer avatar Apr 07 '25 21:04 bshaffer

Brent, we will discuss about the release tomorrow.

+Mike for PHP review

anandolee avatar Apr 07 '25 21:04 anandolee

Thank you @zhangskz !

bshaffer avatar Apr 21 '25 17:04 bshaffer

Hey @bshaffer ! Is there a timeline to update the googleapi public protos to use v25.7? Thanks for the effort thus far 🙏

TomBrouws avatar Apr 30 '25 14:04 TomBrouws

@TomBrouws Hey Tom! We are currently blocked because Java can't upgrade to v25.7 as it could be a breaking change for them... I wish it wasn't as complicated as it has been, but unfortunately it is. We are still looking for ways to make it happen, but there's no ETA yet.

bshaffer avatar Apr 30 '25 15:04 bshaffer

I spoke too soon - it's looking promising for us to make this change. I'll keep this bug updated on our progress!

bshaffer avatar Apr 30 '25 15:04 bshaffer