protobuf
protobuf copied to clipboard
fix(php): do not throw deprecated warning on field getters for default values
backports the fix in #17788 for the 25.x branch, fixes https://github.com/protocolbuffers/protobuf/issues/13428 in 25.x branch
Hi Brent, from April 7 we will drop 25 support for everything except Java
@anandolee When you say "drop", do you mean "release"? And if so can we really try to get this merged before then?
@anandolee My customer would very much appreciate this being merged.
Expanding on this to say that because the googleapi public protos are on protobuf 25, all the client libraries generate messages using that protobuf version. We are trying to update it, but it's difficult since we need to do it for ALL languages at once, and there are some breaking change concerns with some languages for upgrading to 26.
This is a simple fix which is backported to 25 so we can resolve the issue for our customers now, instead of having to wait to upgrade protobuf for all the client libraries (which may be soon, and it may not be).
Brent, we will discuss about the release tomorrow.
+Mike for PHP review
Thank you @zhangskz !
Hey @bshaffer ! Is there a timeline to update the googleapi public protos to use v25.7? Thanks for the effort thus far 🙏
@TomBrouws Hey Tom! We are currently blocked because Java can't upgrade to v25.7 as it could be a breaking change for them... I wish it wasn't as complicated as it has been, but unfortunately it is. We are still looking for ways to make it happen, but there's no ETA yet.
I spoke too soon - it's looking promising for us to make this change. I'll keep this bug updated on our progress!