protobuf.js icon indicating copy to clipboard operation
protobuf.js copied to clipboard

Using `keepCase` option here would have helped in this example

Open troyatomic opened this issue 3 years ago • 0 comments

I think this line in the example ...

https://github.com/protobufjs/protobuf.js/blob/67fe5926da6dc5ed0ea04f0784f3bf8f19333cd5/README.md?plain=1#L233

should be changed to ...

protobuf.load("awesome.proto", { keepCase: true}, function(err, root) { // keepCase is needed since snake_case property is used

since the example uses snake_case fields.

Either that or change the example not to use snake_case properties and instead use camelCase as the style guide recommends. But if you do this, then please mention the keepCase option as it is needed if BigQuery fields use snake_case.

troyatomic avatar Sep 12 '22 22:09 troyatomic