protobuf.js icon indicating copy to clipboard operation
protobuf.js copied to clipboard

pbjs/sparse: fix namespace replacement, include transitive dependencies

Open imirkin opened this issue 4 years ago • 1 comments

This fixes sparse mode for my use-case. Protos are spread over several files, and may include nested messages/enums from other files. Additionally, this fixes the case where a Type is replaced by a Namespace, e.g. when an enum is used without its containing message type.

Fixes #1436

imirkin avatar Dec 30 '20 03:12 imirkin

This looks reasonable, we'll just need some more time to review the change and we'll get back to you @imirkin. Thanks for the PR!

alexander-fenster avatar Mar 13 '21 00:03 alexander-fenster

Is there any progress on this please? @alexander-fenster

binsee avatar Sep 23 '22 06:09 binsee

Is there any chance this will ever get in? Should I just close it? Rebase it?

I can't use --sparse without this patch, since the current logic ends up over-removing types which are actually in use.

imirkin avatar Jun 02 '23 16:06 imirkin