Propel2 icon indicating copy to clipboard operation
Propel2 copied to clipboard

[BEHAVIOR] Add ability to choose between DATETIME and TIMESTAMP

Open wollanup opened this issue 2 years ago • 2 comments

Closes https://github.com/propelorm/Propel2/issues/1971

wollanup avatar Sep 16 '23 10:09 wollanup

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 89.27%. Comparing base (4f36eea) to head (85745f9). :warning: Report is 70 commits behind head on master. :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1978   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
- Complexity     8049     8052    +3     
=========================================
  Files           232      232           
  Lines         24519    24521    +2     
=========================================
+ Hits          21889    21891    +2     
  Misses         2630     2630           
Flag Coverage Δ
5-max 89.27% <100.00%> (+<0.01%) :arrow_up:
7.4 89.27% <100.00%> (+<0.01%) :arrow_up:
agnostic 67.47% <100.00%> (+<0.01%) :arrow_up:
mysql 69.84% <100.00%> (+0.03%) :arrow_up:
pgsql 69.87% <100.00%> (+0.03%) :arrow_up:
sqlite 67.81% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 18 '23 15:09 codecov-commenter

Hi @michbeck and @dereuromark ! If you're interested by this PR, could you help me with the tests errors (8.2, pgsql) please ? I'm not sure to find the cause easily. Maybe a problem saving a book [here] ?(https://github.com/propelorm/Propel2/blob/4f36eea97eb5fcf451a4f80430a728be92b70ac8/tests/Propel/Tests/Runtime/ActiveQuery/ExistsTest.php#L254)

Thanks for any help !

wollanup avatar Sep 18 '23 15:09 wollanup

@PhilinTv this can be closed too I think. You can already specify the type (see #1971).

smhg avatar Jul 06 '25 18:07 smhg