test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Rewrite load-generator in Go

Open SuperQ opened this issue 1 year ago • 9 comments

The /tools/load-generator is the only component of this repo that is in Python. It would be nice to replace this with a Go binary in order to eliminate the Python ecosystem dependency for one tool. There are also no CI tests for this Python code, so we don't know if it's broken when Python or other requirements change.

SuperQ avatar Jun 16 '24 13:06 SuperQ

I would like to pick this up.

Vandit1604 avatar Aug 19 '24 21:08 Vandit1604

@SuperQ PTAL https://github.com/prometheus/test-infra/pull/725

HarshitNagpal29 avatar Aug 27 '24 23:08 HarshitNagpal29

Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine. Please ask in future if somebody is working on an issue to minimize wasted effort.

Other than that, the PR looks good. Thanks again.

Vandit1604 avatar Aug 29 '24 20:08 Vandit1604

Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine. Please ask in future if somebody is working on an issue to minimize wasted effort.

Other than that, the PR looks good. Thanks again.

I am really sorry for not asking first, I thought you might not be working on it as it was assigned earlier but again completely my fault I should have communicated with you, will take care of this in future.

HarshitNagpal29 avatar Aug 29 '24 22:08 HarshitNagpal29

@Vandit1604 If you don't open a PR, nobody knows you're working on it. :smile:

SuperQ avatar Aug 30 '24 04:08 SuperQ

Apologies, I didn't know that.

Vandit1604 avatar Aug 30 '24 05:08 Vandit1604

Feel free to submit your own solution. The current one does not pass tests.

SuperQ avatar Aug 30 '24 05:08 SuperQ

I checked and found out that http://prombench.prometheus.io/14515/prometheus-pr is not found and is causing the querier to fail, with more than 30 404 status code is returned. I'll investigate the manifest files to see if there's some issue in nginx-ingress configurations.

Vandit1604 avatar Aug 31 '24 12:08 Vandit1604

Fixed in #748

SuperQ avatar Sep 21 '24 15:09 SuperQ

I believe https://github.com/prometheus/test-infra/issues/688#issuecomment-2365227765 closed it.

bwplotka avatar Dec 04 '24 09:12 bwplotka