docs icon indicating copy to clipboard operation
docs copied to clipboard

Add webscraper-exporter to the exporters list

Open cestef opened this issue 3 years ago • 9 comments

Signed-off-by: cstef [email protected]

An exporter for website performance metrics built using puppeteer: https://github.com/cstefFlexin/webscraper-exporter

CLI preview:

image

/ endpoint:

image

Metrics exposed:

image

cestef avatar Feb 14 '22 19:02 cestef

Did you close this on purpose?

Both the metric and the label names would need some work; I would be happy to help you polish them.

RichiH avatar Aug 08 '22 15:08 RichiH

I just realised I closed it by accident when adding the lastest commit, thank you so much for sending this message 😭

cestef avatar Aug 08 '22 17:08 cestef

I would be very grateful if you could help me rename the metrics etc. I'm pretty new to the prometheus ecosystem...

cestef avatar Aug 08 '22 17:08 cestef

No problem! You should prefix them with a name, in your case I think it's webscraper_ and suffix them with the unit, so:

Metrics should be in base units, so duration should be in seconds, and probably named webscraper_test_duration_seconds

heap_usage should probably be webscraper_heap_usage_bytes

CPU usage should ideally be in seconds and also allow users to calculate a total; that way they can calculate the % themselves as they need. If you can only do %, then webscraper_cpu_usage_percent would be OK.

bytes_in would be better as webscraper_in_bytes

RichiH avatar Aug 09 '22 08:08 RichiH

Also, can you please sign your commits? See e.g. https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

RichiH avatar Aug 09 '22 08:08 RichiH

Thank you very much ! I'll update the metrics accordingly asap

cestef avatar Aug 09 '22 09:08 cestef

Sorry for all the useless logs from github about me force-pushing commits or whatever, it was a complete mess so I just started over from scratch 😅 I renamed the metrics following what you said, so it should be all good now !

cestef avatar Aug 09 '22 21:08 cestef

These are now the metrics exposed: image

cestef avatar Aug 09 '22 21:08 cestef

Any updates on this ? Would love to have my work featured :D

cestef avatar Aug 18 '23 13:08 cestef