common icon indicating copy to clipboard operation
common copied to clipboard

Add HTTP headers support to common HTTP client.

Open roidelapluie opened this issue 2 years ago • 3 comments
trafficstars

This is named http_headers so it does not clash with blackbox exporter's headers and Prometheus remote client's headers, which are simple maps.

Signed-off-by: Julien Pivotto [email protected]

roidelapluie avatar Nov 28 '22 10:11 roidelapluie

Mailing list discussion: https://groups.google.com/g/prometheus-developers/c/p9HTlPzwUEo

roidelapluie avatar Nov 28 '22 10:11 roidelapluie

Wondering if this will enable what was intended in https://github.com/prometheus/common/pull/326

jeromeinsf avatar Dec 07 '22 00:12 jeromeinsf

@roidelapluie @LeviHarrison what is status in this PR? At least I am interested of this feature

zetaab avatar Dec 30 '23 12:12 zetaab

Me too! Adding headers to requests is a relatively trivial operation and multiple APIs support that

Dronec avatar Apr 10 '24 05:04 Dronec

Just some small revisions

@roidelapluie friendly ping

LeviHarrison avatar Apr 14 '24 18:04 LeviHarrison

@LeviHarrison here you go 🙂

roidelapluie avatar Apr 16 '24 12:04 roidelapluie

@roidelapluie I think this PR introduced an issue in JSON marshalling. Could you take a look at https://github.com/prometheus/common/pull/651 please?

pracucci avatar Jun 07 '24 14:06 pracucci

@roidelapluie any chance you could update the docs to reflect the existence of http_headers ?

CTRL-F of the docs yields zero results for http_headers

udf2457 avatar Aug 24 '24 19:08 udf2457

https://github.com/prometheus/prometheus/pull/14660/files

roidelapluie avatar Aug 29 '24 08:08 roidelapluie