blackbox_exporter icon indicating copy to clipboard operation
blackbox_exporter copied to clipboard

Published 20 hours ago • verified publisher icon prometheus

Add stale workflow for pull request and issues

Open electron0zero opened this issue 1 year ago • 3 comments

Add github actions workflow using https://github.com/actions/stale.

It runs everyday and marks issues and pull requests stale with no activity in last 90 days, and it will close stale issues and pull requests without activity for 30 days (120 days before an issue is closed)

issues and pull requests that has label keepalive, dependencies, or bug will be excluded by the workflow.

goal of this workflow is to make it easier for maintainer to maintain the project and close out old issues and PR with automation and save maintainers time :)

ps: when we merge this PR, this workflow will mark issues and pull requests stale that had no activity in last 90 days.

electron0zero avatar Dec 11 '23 10:12 electron0zero

I wonder if we should have a Prometheus dev discussion about stale bot. I would prefer to keep this setup consistent between projects.

SuperQ avatar Dec 11 '23 10:12 SuperQ

I wonder if we should have a Prometheus dev discussion about stale bot. I would prefer to keep this setup consistent between projects.

yes, I was looking to see how prometheus does it, and found this PR, which links to Prometheus 2019 Dev Summit 2, which says:

Beorn: General repository health

  • Should be use a bot to mark PRs as stale & close them?
  • CONSENSUS: We should have a bot mark PRs as stale, all repos, 60 days.

but it's using probot app, which is archived now.

Option 1: align this bot's config to match what we have in prometheus/prometheus, but I would prefer to use https://github.com/actions/stale because https://github.com/probot/stale is archived :)

Option 2: I can raise a PR in prometheus/prometheus to use https://github.com/actions/stale, and start a discussion in the mailing list to get consesus on it. once approved, we can use that in our repo, and other exporters.

I am leaning towards option 2.

electron0zero avatar Dec 11 '23 14:12 electron0zero

My recommendation

  • Open a PR to convert prometheus/prometheus from probot/stale to actions/stale.
  • Keep the behavior as specified in the old config.
  • Add the stale.yml to scripts/sync_repo_files.sh so that it's copied everywhere.
  • Cleanup the old probot version that's still hanging around in a few places.

There's no need for a new consensus, as we already decided that we should have this everywhere. We just didn't roll it out. :joy_cat:

SuperQ avatar Dec 11 '23 14:12 SuperQ

opened https://github.com/prometheus/prometheus/pull/14650.

going to close this because once https://github.com/prometheus/prometheus/pull/14650 is merged, config will be synced to our repo.

electron0zero avatar Aug 09 '24 17:08 electron0zero