elasticsearch_exporter icon indicating copy to clipboard operation
elasticsearch_exporter copied to clipboard

feat: add duration metrics for collectors

Open sysadmind opened this issue 4 years ago • 6 comments

adds metrics to capture duration of time spent collecting metrics for:

  • cluster_health
  • clustersettings
  • index_stats
  • node_stats
  • snapshot_stats

this feature was adapted from the caarlos0/elasticsearch_exporter repo.

There seem to be a lot of metrics missing from the README, so I just added the metrics that this PR addresses, but I want to ensure that all metrics are in the README in a future PR.

sysadmind avatar Jun 01 '21 15:06 sysadmind

Hmm, typically we add this kind of thing as a gauge. For example in the node_exporter, this is how we handle it.

SuperQ avatar Jun 07 '21 11:06 SuperQ

Thanks for the feedback @SuperQ! I have updated the metrics be be gauge types.

sysadmind avatar Jun 08 '21 14:06 sysadmind

Curious in this one too. I'd like to see if we have a performance issues with queries and it's a bit hard to see right now.

LaurentDumont avatar Aug 19 '21 13:08 LaurentDumont

@SuperQ We have been talking about a refactor, would these changes be better suited to be included there?

sysadmind avatar Jan 19 '22 14:01 sysadmind

This needs a rebase.

SuperQ avatar Jul 28 '22 08:07 SuperQ

this metrics might be really useful, any chance this PR will get processed?

smowky avatar Mar 01 '24 17:03 smowky