Avalanche doesn't send remote-write requests when --metric-interval alone is set

[harry671003]

Issue

• Thanos uses avalanche in e2e tests. About two weeks ago, one of the e2e tests which uses avalanche started failing.
• The test was configuring --metric-interval=30s and --remote-write-interval=30s and expecting requests to be made every 30s from avalanche.
• However, in write.go#L143 no timeseries is returned and avalanche doesn't make write requests.

Avalanche configuration

Avalanche configuration that wasn't working

--metric-count=10 \
--series-count=1 \
--metric-interval=30 \
--series-interval=3600 \
--value-interval=3600 \
--remote-write-interval=30s \
--remote-batch-size=10 \
--remote-requests-count=5

Avalanche configuration that worked

--metric-count=10 \
--series-count=1 \
--metric-interval=3600 \
--series-interval=30 \
--value-interval=30 \
--remote-write-interval=30s \
--remote-batch-size=10 \
--remote-requests-count=5

Related

https://github.com/thanos-io/thanos/pull/7620

[cstyan]

hey @harry671003, can you share more details about what you're seeing?

I see samples being sent correctly when testing locally with both sets of CLI arguments you've provided.

[bwplotka]

We changed a bit of code since you last check. Do you mind double checking if this is still the case?

[harry671003]

It still seems to be a problem in 0.7.0.