mgorny-dev-scripts icon indicating copy to clipboard operation
mgorny-dev-scripts copied to clipboard

Rename pkgdiff to pkgcmp to prevent collision with dev-util/pkgdiff

Open Flowdalic opened this issue 3 years ago • 6 comments

Signed-off-by: Florian Schmaus [email protected]

Flowdalic avatar Jun 10 '22 08:06 Flowdalic

It would be really great to be able to install dev-util/pkgdiff and your dev scripts at the same time. :)

Flowdalic avatar Jun 10 '22 08:06 Flowdalic

Can't you just use diffoscope instead? :P

It's a shame to harm all of our muscle memories, but meh. I'd like to be able to use dev-util/pkgdiff too.

thesamesam avatar Jun 10 '22 08:06 thesamesam

Can't you just use diffoscope instead? :P

Ha, thanks for the pointer. I was looking for tools to compare two archives and found pkgdiff, but was unable to emerge it due it being blocked by mgorny-dev-scripts. We may should consider mentioning diffoscope in devmanual (not that I believe I would have found it in that case, but it sure couldn't hurt).

It's a shame to harm all of our muscle memories, but meh. I'd like to be able to use dev-util/pkgdiff too.

I don't have a strong opinion on this. This PR is basically just asking mgorny if he would consider changing the binaries name. I totally get that there a valid reasons to keep the name and to reject the PR.

Flowdalic avatar Jun 11 '22 09:06 Flowdalic

To be honest, I can't really think of a good solution. As @thesamesam pointed out, our muscle memory is strong, and unfortunately I wasn't aware of the problem until I've actually packaged it. I feel it's a bit late to change the name.

mgorny avatar Jun 11 '22 11:06 mgorny

That's perfectly fine, not unexpected and understandable.

Flowdalic avatar Jun 11 '22 12:06 Flowdalic

I suppose one option would be to rename and install a compat symlink under a USE flag.

mgorny avatar Jun 11 '22 12:06 mgorny

https://github.com/projg2/mgorny-dev-scripts/commit/dbbdef4db0f8e7e11bf632be66b47106ee16a59c

thesamesam avatar Mar 05 '23 15:03 thesamesam