Badget icon indicating copy to clipboard operation
Badget copied to clipboard
verified publisher icon projectx-codehagen

Makes Stripe integration optional

Open michaelwschultz opened this issue 1 year ago • 4 comments

Description

Stripe seems like it isn't necessary right now and in fact something that is a deterrent for local development. For now, I commented out the place it's used so it can be brought back easily. Not sure that commented code follows the current guidelines. If so, happy to remove it altogether.

I also left the env variables in the .env.example but made it clear they are optional. They are still required by the type checker, but since there are defaults, I thought this would be fine. This makes commenting out the code simple as well since there isn't a bunch of stuff that needs to be removed in order to satisfy the removal of the env variables.

What type of PR is this? (check all applicable)

  • [ ] 💡 Feature
  • [x] 🐛 Bug Fix
  • [ ] 📝 Documentation Update
  • [ ] 🎨 Style
  • [ ] 🧑‍💻 Code Refactor
  • [ ] 🔥 Performance Improvements
  • [ ] ✅ Test
  • [ ] 🤖 Build
  • [ ] 🔁 CI
  • [ ] 📦 Chore (Release)
  • [ ] ⏩ Revert

Related Tickets & Documents

Closes: #112

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. visit dashboard
  2. bask in the glory of the ability to see your dashboard without needing Stripe env variables

Added to documentation?

  • [x] 📜 README.md
  • [ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

by for now

michaelwschultz avatar Feb 28 '24 10:02 michaelwschultz

@michaelwschultz is attempting to deploy a commit to the Salgsmaskin Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 28 '24 10:02 vercel[bot]

I guess I'm curious if Stripe is even needed at this point. Is there a product write up anywhere that talks about what is needed for MVP?

michaelwschultz avatar Feb 28 '24 21:02 michaelwschultz

@michaelwschultz I dont think stripe is needed at this point. We should just remove the dependency for it for now (just my thought)

akinwol avatar Mar 04 '24 20:03 akinwol

@michaelwschultz I dont think stripe is needed at this point. We should just remove the dependency for it for now (just my thought)

We only need Stripe in hosted version. So we can avoid it as I wrote days ago, via an env var.

@matteobad

alexghirelli avatar Mar 04 '24 20:03 alexghirelli