mesa
mesa copied to clipboard
ABM language
Per discussion creating additional pull request for ABM improvement as discussed in PR #1278
As stated in https://github.com/projectmesa/mesa/pull/1278#discussion_r848981392, the methods should be defined in a new class that inherits from mesa.Agent, because it's not the majority of the model that needs the methods.
Also, as stated in https://github.com/projectmesa/mesa/pull/1278#discussion_r848984306.
Codecov Report
Merging #1354 (89d6286) into main (241924d) will decrease coverage by
1.93%. The diff coverage is31.91%.
@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
- Coverage 91.03% 89.10% -1.94%
==========================================
Files 19 18 -1
Lines 1339 1395 +56
Branches 257 261 +4
==========================================
+ Hits 1219 1243 +24
- Misses 85 117 +32
Partials 35 35
| Impacted Files | Coverage Δ | |
|---|---|---|
| mesa/agent.py | 43.75% <31.91%> (-32.73%) |
:arrow_down: |
| mesa/visualization/modules/__init__.py | 100.00% <0.00%> (ø) |
|
| ...a/visualization/modules/CanvasGridVisualization.py | 95.83% <0.00%> (ø) |
|
| mesa/visualization/modules/TextVisualization.py | ||
| mesa/visualization/ModularVisualization.py | 78.80% <0.00%> (+1.99%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 241924d...89d6286. Read the comment docs.
Thanks @GaelLucero for continuing to work on this. We are here to help so don't hesitate to ask any clarifying questions if one of our comments doesn't make sense or we can even jump on a quick video chat if you want. This is a big project much bigger than a typical first contribution.
Looks quite awesome @GaelLucero! Are you still working on this? Anything that needs to be discussed?
I'm still interested in this. Maybe we can create some subclass called "PhysicalSpace" or "NewtonianSpace", which implements movement and direction but also energy, momentum and power.