httpx
httpx copied to clipboard
projectdiscovery
Feat: added a new parameter -js to javascript injection in headless
Now the -js and --javascript-inject options execute code in the session browser without a head to change, for example, "local storage` or any other scripts
Example:
index.html
<!DOCTYPE html>
<html>
<head>
<title>check</title>
</head>
<body>
<h1>check</h1>
<script>
const check = () => {
const h1 = document.querySelector('h1')
h1.innerText += JSON.stringify(window.localStorage);
h1.innerHTML += '<br />';
}
check();
setInterval(() => {
check();
}, 1000);
</script>
</body>
</html>
t.js tt.js ttt.js
() => window.localStorage.setItem("a", "boba") // t.js
() => window.localStorage.setItem("ab", "oba") // tt.js
() => window.localStorage.setItem("abo", "ba") // ttt.js
echo 'http://127.0.0.1:8888/' | ./httpx -sid 15 -js "$(cat ./t.js)" -ss -srd ./test -js "$(cat ./tt.js)" --javascript-inject $(cat tt.js)
If something needs improvement, then write, I am open to change
@michael2to3 thank you for the PR, can you please create issue and link back to this PR with information including use case and example.
If the JavaScript is executed only after waitStable or domStable, the user won't have the ability to control the state before the DOM is fully loaded, which is sometimes necessary. If the user needs to execute code specifically after the DOM is loaded, they can choose the event that suits their needs best. For instance, in the case of DOM stability, window.onload = () => {...} seems appropriate.
Thus, I suggest executing eval immediately after navigation. This approach will provide more flexibility for the user
If the JavaScript is executed only after
waitStableordomStable, the user won't have the ability to control the state before the DOM is fully loaded, which is sometimes necessary. [...]
Can you give an example use case for that?
Thus, I suggest executing
evalimmediately after navigation. This approach will provide more flexibility for the user
Looks like we need to update the flag description, specifically by removing the phrase "after DOM content loaded".
After reviewing the a7e821c changes, EvalJavascript is still being invoked inside ScreenshotWithBody method, which relies on the -ss/-screenshot flag. it really should be independent of that.
Can you give an example use case for that?
In my case, the website loaded JavaScript immediately and redirected to the registration page if it didn’t find specific variables in localStorage. Executing JavaScript right away allowed me to set those variables before the check.
Looks like we need to update the flag description, specifically by removing the phrase "after DOM content loaded".
I’ve updated the flag description as suggested – apologies for missing that earlier.
After reviewing the a7e821c changes,
EvalJavascriptis still being invoked insideScreenshotWithBodymethod, which relies on the-ss/-screenshotflag. it really should be independent of that.
The dependency of -jsc on -ss is intentional since httpx only executes JavaScript in headless mode, enabled by the -ss option. Without it, JavaScript execution won’t occur.
If I’m mistaken and httpx can run JavaScript without -ss, please let me know, and I’ll adjust the code.
In my case, the website loaded JavaScript immediately and redirected to the registration page if it didn’t find specific variables in
localStorage. Executing JavaScript right away allowed me to set those variables before the check.
+1 makes sense.
If I’m mistaken and
httpxcan run JavaScript without-ss, please let me know, and I’ll adjust the code.
Thoughts on this, @Mzack9999?
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. Please update if you wish to keep it open.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically closed due to inactivity. If you think this is a mistake or would like to continue working on it, please comment or feel free to reopen it.