calico icon indicating copy to clipboard operation
calico copied to clipboard

fix(charts/tigera-operator): openshift provider

Open unai-ttxu opened this issue 1 year ago • 3 comments
trafficstars

Description

Fixes installation of calico tigera-operator when installation.kubernetesProvider is set to OpenShift.

Currently some resources are not created when installation.kubernetesProvider is set to OpenShift since the comparision is case sensitive. Since installation.kubernetesProvider values are limited to ["", EKS, GKE, AKS, OpenShift, DockerEnterprise, RKE2, TKG] due to Installation CRD schema we need to adapt the conditional.

Related issues/PRs

None

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Release note

Release Note

Helm: Fix OpenShift provider

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

unai-ttxu avatar Oct 03 '24 16:10 unai-ttxu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 03 '24 16:10 CLAassistant

@unai-ttxu sorry for missing this one!

The changes LGTM - but you may need to run make generate in order to update manifests, etc., that are based on this.

caseydavenport avatar Oct 22 '24 16:10 caseydavenport

/sem-approve

caseydavenport avatar Oct 22 '24 17:10 caseydavenport

@unai-ttxu sorry for missing this one!

The changes LGTM - but you may need to run make generate in order to update manifests, etc., that are based on this.

Thank you so much for the review and the approval :smile:. I see that finallly the manifests update was not necessary. If you need anything let me know.

unai-ttxu avatar Nov 06 '24 09:11 unai-ttxu