calico icon indicating copy to clipboard operation
calico copied to clipboard

Enable/Add Felix FV Test Support on arm64

Open TrevorTaoARM opened this issue 3 years ago • 7 comments

Add support for Feliv FV test on arm64:

  1. Add ARCH env support in Makefile
  2. Add Multi-arch support in Dockerfile.amd64(for which Dockerfile sw links to), now the building in Makefile uses a single Dockerfile, instead of Dockerfile.$(arch).
  3. Use arch realated image for various images(felix, bpftool) used in test.
  4. Add multi-arch support(ETCD_UNSUPPORTED_ARCH) to Etcd container running environment.

Those changes have been tested on both arm64 and amd64 platforms. The test results showed it works for both arm64 and amd64 platforms.

Those changes should also work for other architectures(ppcle64, ...), but not tested here.

Signed-off-by: TrevorTaoARM [email protected] Change-Id: Ifca00a88d0164073c5be2c910eced1839a078a28

Signed-off-by: TrevorTaoARM [email protected]

Description

Related issues/PRs

https://github.com/projectcalico/calico/issues/6199

If appropriate, add links to any number of PRs documented by this PR documents <PR LINK> -->

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

TrevorTaoARM avatar Jun 14 '22 11:06 TrevorTaoARM

/sem-approve

fasaxc avatar Jun 14 '22 12:06 fasaxc

Hi Team,

Any updates on PR? When are you planning to merge it?

odidev avatar Jun 20 '22 05:06 odidev

/sem-approve

caseydavenport avatar Jul 15 '22 16:07 caseydavenport

Sorry for the delay here. Kicking off a test run.

caseydavenport avatar Jul 15 '22 16:07 caseydavenport

make check-dirtyFailed in 
00:00
The following files are dirty00:00
 felix/fv/infrastructure/etcd.go       | 29 +++++++++++++++--------------00:00
 felix/fv/infrastructure/felix.go      |  4 ++--00:00
 felix/fv/infrastructure/infra_etcd.go |  4 ++--00:00
 felix/fv/infrastructure/infra_k8s.go  | 10 +++++-----00:00
 4 files changed, 24 insertions(+), 23 deletions(-)00:00
lib.Makefile:1116: recipe for target 'check-dirty' failed00:00
make: *** [check-dirty] Error 1

Looks like there are some out of date generated files - probably need to run make generate

caseydavenport avatar Jul 22 '22 17:07 caseydavenport

Although I didn't think those files were generated...

caseydavenport avatar Jul 22 '22 17:07 caseydavenport

make check-dirtyFailed in 
00:00
The following files are dirty00:00
 felix/fv/infrastructure/etcd.go       | 29 +++++++++++++++--------------00:00
 felix/fv/infrastructure/felix.go      |  4 ++--00:00
 felix/fv/infrastructure/infra_etcd.go |  4 ++--00:00
 felix/fv/infrastructure/infra_k8s.go  | 10 +++++-----00:00
 4 files changed, 24 insertions(+), 23 deletions(-)00:00
lib.Makefile:1116: recipe for target 'check-dirty' failed00:00
make: *** [check-dirty] Error 1

Looks like there are some out of date generated files - probably need to run make generate

@caseydavenport I will check it some time later. Thank you. I had rebased my changes in this commit. Please check it.

TrevorTaoARM avatar Jul 23 '22 00:07 TrevorTaoARM

Not sure why but it looks like CI is failing due to the dirty files check: https://tigera.semaphoreci.com/jobs/25afeb89-ec03-4da5-bcda-00dc97680a5f

lmm avatar Sep 06 '22 16:09 lmm

/sem-approve

frozenprocess avatar Sep 11 '22 16:09 frozenprocess

Hi Team,

Any updates on PR?

odidev avatar Oct 19 '22 12:10 odidev

Updated with PR: https://github.com/projectcalico/calico/pull/6989 Should I just abandon this PR?

@TrevorTaoARM Yep we can use the other PR.

caseydavenport avatar Nov 14 '22 11:11 caseydavenport