container-storage-setup icon indicating copy to clipboard operation
container-storage-setup copied to clipboard

Should docker start or fail if docker-storage-setup fails

Open rhvgoyal opened this issue 10 years ago • 4 comments

Currently if docker-storage-setup fails, docker still starts and falls back to using loopback devices. Is this the right behavior. Or docker should fail to as docker-storage-setup failed.

Opening this issue for having a conversation on this topic.

rhvgoyal avatar Jul 28 '15 14:07 rhvgoyal

I think given we're only warning people against using loopback rather than disabling it all together that docker should still start if d-s-s fails. We provide plenty of ongoing feedback to users that it's not a supported configuration and they need to setup storage properly.

sdodson avatar Jul 28 '15 15:07 sdodson

I think in the future we should force the configuration of docker storage, but the information for doing this needs to be easily found in the systemctl status docker message.

But we have to handle upgrades properly and know if a user is currently using loopback and not fail. Also we need to complete the atomic migrate scripts to allow them to get off of loopback onto a production quality backend.

rhatdan avatar Jul 28 '15 15:07 rhatdan

Sorry, I see from the #60 that we're looking at making loopback opt-in. If that's the case then fine with making d-s-s mandatory

sdodson avatar Jul 28 '15 15:07 sdodson

@sdodson That is the way we are trending. Lots of stuff needs to be done before we make the switch though. Also need Product Management to approve the idea...

rhatdan avatar Jul 28 '15 18:07 rhatdan