zot icon indicating copy to clipboard operation
zot copied to clipboard

[feat] support custom GitHub OAuth2 auth and token URLs

Open analytically opened this issue 8 months ago • 5 comments

Feature

Which issue does this PR fix:

Support custom Github OAuth2 auth and token URLs

analytically avatar Mar 12 '25 17:03 analytically

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (c87f489) to head (fd87859).

Files with missing lines Patch % Lines
pkg/api/authn.go 50.00% 4 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
- Coverage   90.96%   90.95%   -0.02%     
==========================================
  Files         176      176              
  Lines       32940    32951      +11     
==========================================
+ Hits        29965    29970       +5     
- Misses       2245     2249       +4     
- Partials      730      732       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 12 '25 18:03 codecov[bot]

@analytically can you also add a test to verify the new configuration?

andaaron avatar Mar 12 '25 18:03 andaaron

@andaaron a test that runs against GitHub Enterprise? Or just config object validation?

analytically avatar Mar 12 '25 18:03 analytically

I was thinking maybe we could mock it, similar to what we have in https://github.com/project-zot/zot/blob/c87f489a7995a06a16c967dcb8090d27b3f1cc15/pkg/test/auth/oidc.go#L13

andaaron avatar Mar 12 '25 18:03 andaaron

Support custom Github OAuth2 auth and token URLs

^ could you also point to pointers/docs about why this PR is needed.

@analytically thanks for taking the time for this PR.

rchincha avatar Mar 12 '25 18:03 rchincha

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 25 '25 02:10 github-actions[bot]