project-robius
Add image viewer widget
Fixes #327
in replacement of https://github.com/project-robius/robrix/pull/443
Waiting for this PR to be merged: https://github.com/makepad/makepad/pull/788.
Intention of adding an image magnifier and the ability to pan image.
The image's image_scale, image_pan will always be set to default in draw_walk. Hence unable to dynamically scale and pan image. https://github.com/makepad/makepad/issues/785
Intention of adding an image magnifier and the ability to pan image.
The image's image_scale, image_pan will always be set to default in draw_walk. Hence unable to dynamically scale and pan image. makepad/makepad#785
@alanpoon I just checked with Rik, and this line should not be present in the Image widget. It's some errant code left over from dealing with animations in a strange way.
You can submit a PR to makepad that removes that line, and then continue with this issue here.
Sure, the makepad PR is here: https://github.com/makepad/makepad/pull/788/
Requires https://github.com/makepad/makepad/pull/806 to be merged to use the rotated_image widget
Requires makepad/makepad#806 to be merged to use the rotated_image widget
I've asked Rik to review & merge this.
Requires makepad/makepad#806 to be merged to use the rotated_image widget
I've asked Rik to review & merge this.
@alanpoon this PR has been merged, and I've also updated the main Robrix branch to depend on the latest makepad.
@alanpoon i finally fully fixed all Modal issues in Makepad, or at least I think I did. PR #632 should resolve all of your modal problems; please let me know if it works or if there are still some remaining problems.
@alanpoon i finally fully fixed all Modal issues in Makepad, or at least I think I did. PR #632 should resolve all of your modal problems; please let me know if it works or if there are still some remaining problems.
I have merged main into my branch. There is no more event propagation to the beneath layer. I don't think there is anymore outstanding issues. Please kindly review.